Use PlatformNames contants for platform exclusions#6606
Open
0xced wants to merge 2 commits into
Open
Conversation
MacOsX with a lowercase s is just too ugly 🙈
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates NUnit [Platform] usage in tests to use PlatformNames constants instead of raw string literals for platform exclusions.
Changes:
- Replaced
Exclude = "Win"withExclude = PlatformNames.Winin SSL-related security tests. - Replaced
Exclude = "MacOsX"withExclude = PlatformNames.MacOSXacross multiple test suites. - Kept existing skip reasons while standardizing platform identifiers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| test/Npgsql.Tests/SecurityTests.cs | Switches platform exclusion strings to PlatformNames constants for Windows/macOS in SSL security tests. |
| test/Npgsql.Tests/MultipleHostsTests.cs | Uses PlatformNames.MacOSX for a macOS-excluded multi-host test. |
| test/Npgsql.Tests/CopyTests.cs | Uses PlatformNames.MacOSX for a macOS-excluded COPY-related test. |
| test/Npgsql.Tests/ConnectionTests.cs | Uses PlatformNames.MacOSX for a macOS-excluded Unix socket test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Since [Fix with Copilot doesn't work](https://hachyderm.io/@0xced/116743002207267259)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MacOsX with a lowercase s is just too ugly 🙈