Skip to content

Fix pgpass and certificate environment logic#3642

Merged
roji merged 2 commits into
mainfrom
EnvironmentSpringCleaning
Apr 9, 2021
Merged

Fix pgpass and certificate environment logic#3642
roji merged 2 commits into
mainfrom
EnvironmentSpringCleaning

Conversation

@roji

@roji roji commented Apr 9, 2021

Copy link
Copy Markdown
Member

@vonzshik we don't have testing for the certificate stuff so a good look would be appreciated!

Fixes #3640
Fixes #3641

@roji
roji requested a review from vonzshik April 9, 2021 08:35
@vonzshik

vonzshik commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

There is also ~/.postgresql/postgresql.key (sslkey), which we're missing.

@vonzshik vonzshik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually pretty hilarious in a hindsight.

Do you mind adding a postgresql.key? We can always fix it in a separate PR.

@roji
roji merged commit fe52cc8 into main Apr 9, 2021
@roji
roji deleted the EnvironmentSpringCleaning branch April 9, 2021 13:35
roji added a commit that referenced this pull request Apr 9, 2021
@roji

roji commented Apr 9, 2021

Copy link
Copy Markdown
Member Author

Backported to 5.0.5 (without the SslKey changes) via 91eee2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client and root certificate paths are wrong on Linux On unix, .pgpass is being looked up in ~/postgresql, not in ~/

2 participants