Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

fix: Dark Mode Button Toggle on Enter Key #1150

Merged
benhalverson merged 3 commits into from
Mar 17, 2021
Merged

fix: Dark Mode Button Toggle on Enter Key #1150

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3cb261
Fixed Dark Mode Button Toggle on Enter Key
manishprivet Mar 13, 2021
258688b
Addressed Changes requested and Fixed Linitng Issues
manishprivet Mar 14, 2021
d65adf1
Merge branch 'master' into dark-mode-button-toggle-fix
benhalverson Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Link } from 'gatsby';
import React from 'react';
import React, { KeyboardEvent } from 'react';
import logoLight from '../../images/logos/nodejs-logo-light-mode.svg';
import logoDark from '../../images/logos/nodejs-logo-dark-mode.svg';
import defaultDarkModeController from '../../util/darkModeController';
Expand All @@ -13,6 +13,13 @@ const Header = ({
darkModeController = defaultDarkModeController,
}: Props): JSX.Element => {
const isMobile = useMediaQuery('(max-width: 870px)');

const keyPressDarkModeHandler: (
e: KeyboardEvent<HTMLButtonElement>
) => void = e => {
if (e.charCode === 13 || e.charCode === 32) darkModeController.toggle();
};

return (
<nav aria-label="Primary" className="nav">
<div className="nav__container">
Expand Down Expand Up @@ -82,6 +89,7 @@ const Header = ({
<button
type="button"
className="dark-mode-toggle"
onKeyPress={keyPressDarkModeHandler}
onMouseDown={darkModeController.handleEvent}
onMouseUp={darkModeController.handleEvent}
>
Expand Down