fix: Dark Mode Button Toggle on Enter Key - #1150
Conversation
|
/preview |
|
Please find a preview at: https://staging.nodejs.dev/1150/ |
rodion-arr
left a comment
There was a problem hiding this comment.
Injecting logic straight into the view seems not really good idea. Wondering if we can reuse existing handler for new event?
|
@rodion-arr I looked for a way if there was one to use the existing handler, but I think it only exists for pointer events. Also, the npm package that we're using for controlling dark mode, @smotaal.io/dark-mode-controller, I can't find its GitHub repository to look into it more. |
|
Hey @SMotaal can you add keypresses to your dark-mode-controller? |
benhalverson
left a comment
There was a problem hiding this comment.
LGTM, we can refactor later if Saleh replies to my ping.
|
Please find a preview at: https://staging.nodejs.dev/1150/ |
|
@benhalverson my apologies for going off-grid, refactoring it out per https://github.com/nodejs/nodejs.dev/issues/1177 is the most practical path forward — keep up the good work 🚀 |
Description
Added the toggle function to the
keyPressevent in Dark Mode ButtonRelated Issues
Fixes #1147