Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix: Speed up font color transition - #1083

Merged
benhalverson merged 2 commits into
nodejs:masterfrom
mikeesto:color-transition
Dec 19, 2020
Merged

Fix: Speed up font color transition#1083
benhalverson merged 2 commits into
nodejs:masterfrom
mikeesto:color-transition

Conversation

@mikeesto

Copy link
Copy Markdown
Member

Description

Speed up font color transition between light/dark modes

Related Issues

Resolves https://github.com/nodejs/nodejs.dev/issues/1081

@mikeesto

Copy link
Copy Markdown
Member Author

/preview

@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1083/

@rodion-arr rodion-arr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on iPhone

@marcustisater

marcustisater commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

Good catch!

Much better, but the font color is still flickering for me.

How would it look with only background color transition? Also, my initial thoughts was to remove transition completly.

It got requested back in issue #1068

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Dec 16, 2020
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Dec 16, 2020
@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1083/

@mikeesto

Copy link
Copy Markdown
Member Author

How would it look with only background color transition? Also, my initial thoughts was to remove transition completly.

This is with only background color transition:

transition

I'm not sure if the GIF will do it justice, but it's what you would imagine no transition to look like. I'm unable to reproduce the flicking on web or mobile. Happy to remove it completely or leave it with a short transition - I think either would be an improvement

@marcustisater

Copy link
Copy Markdown
Contributor

Thanks @mikeesto. @benhalverson do you notice any flickering? Otherwise it might just be cache from my mobile.

Let's merge this but I still would like to investigate if transitions is a good idea or not.

1 similar comment
@marcustisater

Copy link
Copy Markdown
Contributor

Thanks @mikeesto. @benhalverson do you notice any flickering? Otherwise it might just be cache from my mobile.

Let's merge this but I still would like to investigate if transitions is a good idea or not.

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Dec 19, 2020
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Dec 19, 2020
@benhalverson

Copy link
Copy Markdown
Member

I haven't noticed any flickering.
Any idea on why the test-ci is not running in this PR?

@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1083/

@mikeesto

Copy link
Copy Markdown
Member Author

Any idea on why the test-ci is not running in this PR?

I noticed it wasn't running - no idea why. Seems to have sorted itself out now though (?)

@benhalverson

Copy link
Copy Markdown
Member

yep there was a deprecated issue that Myles fixed here. #1085

@benhalverson
benhalverson merged commit dfbcba6 into nodejs:master Dec 19, 2020
@marcustisater

Copy link
Copy Markdown
Contributor

@mikeesto thanks for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode toggle transition for font color swap is slow

4 participants