Fix: Speed up font color transition - #1083
Conversation
|
/preview |
|
Please find a preview at: https://staging.nodejs.dev/1083/ |
|
Good catch! Much better, but the font color is still flickering for me. How would it look with only background color transition? Also, my initial thoughts was to remove transition completly. It got requested back in issue #1068 |
|
Please find a preview at: https://staging.nodejs.dev/1083/ |
This is with only background color transition: I'm not sure if the GIF will do it justice, but it's what you would imagine no transition to look like. I'm unable to reproduce the flicking on web or mobile. Happy to remove it completely or leave it with a short transition - I think either would be an improvement |
|
Thanks @mikeesto. @benhalverson do you notice any flickering? Otherwise it might just be cache from my mobile. Let's merge this but I still would like to investigate if transitions is a good idea or not. |
1 similar comment
|
Thanks @mikeesto. @benhalverson do you notice any flickering? Otherwise it might just be cache from my mobile. Let's merge this but I still would like to investigate if transitions is a good idea or not. |
|
I haven't noticed any flickering. |
|
Please find a preview at: https://staging.nodejs.dev/1083/ |
I noticed it wasn't running - no idea why. Seems to have sorted itself out now though (?) |
|
yep there was a deprecated issue that Myles fixed here. #1085 |
|
@mikeesto thanks for the PR! |

Description
Speed up font color transition between light/dark modes
Related Issues
Resolves https://github.com/nodejs/nodejs.dev/issues/1081