Skip to content

v8: update make-v8.sh to use git #9393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbajwa wants to merge 9 commits into from
Closed

v8: update make-v8.sh to use git #9393

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c3deb42
v8: update make-v8.sh to use git
Nov 1, 2016
3c54a7e
addressed comments and added a rsync command to copy local
Nov 2, 2016
73e7c69
Using git clean quiet option instead of directing stdout to /dev/null
Nov 3, 2016
7d8effd
perform git cleanup for all branches
Nov 4, 2016
fd9fd66
removed passing branch as an argument instead quering from
Nov 4, 2016
0171280
remove unnecessary branch checking
Nov 5, 2016
60bcadb
Addressed comments
Nov 8, 2016
971ef91
Remove .git directory from fetched copy of v8
Nov 8, 2016
8c995f4
Use git stash to preserve local changes
Nov 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
addressed comments and added a rsync command to copy local 
files which are not present in the remote repo.
  • Loading branch information
Jaideep Bajwa committed Nov 2, 2016
commit 3c54a7ea238b7e72ab24a925645bd7e889e0fbb2
6 changes: 4 additions & 2 deletions tools/make-v8.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ function cleanup() {
rm .gclient || true
rm .gclient_entries || true
rm -rf _bad_scm/ || true
rm -rf .v8old
if [ "$BRANCH" == "master" ]; then
echo "git cleanup if branch is master"
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why cleaning up only for master?

Copy link
Copy Markdown
Author

@jbajwa jbajwa Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only need the cleanup for the v8 bundled with node (here master would be v8 master). If you want to test eg v8@5.5, then you don't need the cleanup since thats not the v8 bundled with node and can be tested standalone. Use case for that would be, if you want to test a specific v8 version before merging into node.

Copy link
Copy Markdown
Member

@mhdawson mhdawson Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the case were somebody has a pr and launches the job against their id/repo ?

Copy link
Copy Markdown
Member

@mhdawson mhdawson Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specifically as per my other comment I think we need more info on what BRANCH is. This job tests branches of node.js not v8 so saying you are going to test v8@5.5 does not really make sense to me. If you said test using the tools from v8@5.5 then that might make more sense.

Copy link
Copy Markdown
Author

@jbajwa jbajwa Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launching a job with somebody's pr should still work, since their git repo will be tracking the files they updated. Like the job Ben started with my changes https://ci.nodejs.org/job/node-test-commit-v8-linux/390/
Regarding BRANCH, yes it indeed meant to test specific v8 version if needed, otherwise it will get the tools from V8 master. I might have misunderstood the exact purpose of this job, as you mentioned in the other comment if the purpose is to get the tools of a specific v8 version then I will have to do the cleanup for any branch. Will make the necessary changes.

git ls-files -m | xargs git checkout --
git reset --hard HEAD
git clean -fd >/dev/null
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to bring the tree back to a pristine state consider changing this to -dfx so .gitignored files are also deleted.

Copy link
Copy Markdown
Author

@jbajwa jbajwa Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep the dependencies which are part of .gitignore to be able to build v8 standalone, eg v8/third_party, v8/buildtools etc. git clean -fd should remove the rest of the files that .gitignore doesn't ignore, eg newer src/test files. The goal is to have node/deps/v8 with all the third party dependencies in it.

Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: git clean has a quiet option as well

Copy link
Copy Markdown
Author

@jbajwa jbajwa Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've updated accordingly.

# Copy local files
rsync -a .v8old/ v8/
fi
rm -rf .v8old
exit 0
}

Expand Down