Skip to content

v8: update make-v8.sh to use git #9393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbajwa wants to merge 9 commits into from
Closed

v8: update make-v8.sh to use git #9393

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c3deb42
v8: update make-v8.sh to use git
Nov 1, 2016
3c54a7e
addressed comments and added a rsync command to copy local
Nov 2, 2016
73e7c69
Using git clean quiet option instead of directing stdout to /dev/null
Nov 3, 2016
7d8effd
perform git cleanup for all branches
Nov 4, 2016
fd9fd66
removed passing branch as an argument instead quering from
Nov 4, 2016
0171280
remove unnecessary branch checking
Nov 5, 2016
60bcadb
Addressed comments
Nov 8, 2016
971ef91
Remove .git directory from fetched copy of v8
Nov 8, 2016
8c995f4
Use git stash to preserve local changes
Nov 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary branch checking
  • Loading branch information
Jaideep Bajwa committed Nov 5, 2016
commit 0171280973c190e4c2be5b19f1f56604ada2fd44
6 changes: 2 additions & 4 deletions tools/make-v8.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,8 @@ echo "V8 fetched"
cd v8

echo "Checking out branch:$BRANCH"
if [ "$BRANCH" != "master" ]; then
git fetch
git checkout remotes/branch-heads/$BRANCH
fi
git fetch
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not wrong, fetch v8 will fetch everything. So this may not be necessary.

Copy link
Copy Markdown
Author

@jbajwa jbajwa Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this fetch is not necessary, updated. Thanks.

git checkout remotes/branch-heads/$BRANCH

echo "Sync dependencies"
gclient sync
Expand Down