Skip to content

errors: add internal/errors.js #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 9 commits into from
Closed

errors: add internal/errors.js #9265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0496a78
errors: add internal/errors.js
jasnell Oct 24, 2016
9bbef40
errors: update bootstrap_node.js to use internal/errors
jasnell Oct 24, 2016
5c78767
errors: update internal/util to use internal/errors
jasnell Oct 24, 2016
753b3ef
errors: update internal/socket_list to use internal/errors
jasnell Oct 24, 2016
c9b2093
errors: update internal/net.js to use internal/errors
jasnell Oct 24, 2016
5ae2086
errors: update internal/next_tick.js to use internals/errors
jasnell Oct 24, 2016
9def513
errors: update internal/fs.js to use internal/errors
jasnell Oct 24, 2016
5866425
errors: update internal/url.js to use internal/errors
jasnell Oct 24, 2016
4879291
errors: update internal/child_process.js to use internal/errors
jasnell Oct 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
errors: update bootstrap_node.js to use internal/errors
  • Loading branch information
@jasnell
jasnell committed Oct 25, 2016
commit 9bbef400928cc7159d019b92399671975eec44cf
3 changes: 2 additions & 1 deletion lib/internal/bootstrap_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,8 @@
}

if (!NativeModule.exists(id)) {
throw new Error(`No such native module ${id}`);
const errors = require('internal/errors');
Copy link
Copy Markdown
Member

@targos targos Nov 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: const {Error} = require('internal/errors');

throw new errors.Error('NATIVE_MODULE_NOT_FOUND', id);
}

process.moduleLoadList.push(`NativeModule ${id}`);
Expand Down
1 change: 1 addition & 0 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,4 @@ function E(sym, val) {

// Note: Please try to keep these in alphabetical order
E('ASSERTION_ERROR', (msg) => msg);
E('NATIVE_MODULE_NOT_FOUND', (module) => `No such native module ${module}`);