Skip to content

errors: add internal/errors.js #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 9 commits into from
Closed

errors: add internal/errors.js #9265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0496a78
errors: add internal/errors.js
jasnell Oct 24, 2016
9bbef40
errors: update bootstrap_node.js to use internal/errors
jasnell Oct 24, 2016
5c78767
errors: update internal/util to use internal/errors
jasnell Oct 24, 2016
753b3ef
errors: update internal/socket_list to use internal/errors
jasnell Oct 24, 2016
c9b2093
errors: update internal/net.js to use internal/errors
jasnell Oct 24, 2016
5ae2086
errors: update internal/next_tick.js to use internals/errors
jasnell Oct 24, 2016
9def513
errors: update internal/fs.js to use internal/errors
jasnell Oct 24, 2016
5866425
errors: update internal/url.js to use internal/errors
jasnell Oct 24, 2016
4879291
errors: update internal/child_process.js to use internal/errors
jasnell Oct 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
errors: update internal/url.js to use internal/errors
  • Loading branch information
@jasnell
jasnell committed Oct 25, 2016
commit 586642520f666cc684e2e59eef0fc6303d6ef8d2
1 change: 1 addition & 0 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ E('INVALID_CALLBACK', 'callback is not a function');
E('INVALID_ENCODING', (encoding) => `Unknown encoding: ${encoding}`);
E('INVALID_FILE_OPEN_FLAG', (flag) => `Unknown file open flag: ${flag}`);
E('INVALID_PORT', 'port must be a number >= 0 and <= 65535');
E('INVALID_URL', 'Invalid URL');
E('NATIVE_MODULE_NOT_FOUND', (module) => `No such native module ${module}`);
E('NO_CRYPTO', 'Node.js is not compiled with openssl crypto support');
E('SOCKET_CLOSED_BEFORE_REPLY', 'Socket closed before reply');
6 changes: 4 additions & 2 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const cannotBeBase = Symbol('cannot-be-base');
const special = Symbol('special');
const searchParams = Symbol('query');
const querystring = require('querystring');
const errors = require('internal/errors');

const kScheme = Symbol('scheme');
const kHost = Symbol('host');
Expand Down Expand Up @@ -81,8 +82,9 @@ class URL {
binding.parse(input.trim(), -1, base_context, undefined,
(flags, protocol, username, password,
host, port, path, query, fragment) => {
if (flags & binding.URL_FLAGS_FAILED)
throw new TypeError('Invalid URL');
if (flags & binding.URL_FLAGS_FAILED) {
throw new errors.TypeError('INVALID_URL');
}
this[context].flags = flags;
this[context].scheme = protocol;
this[context].username = username;
Expand Down