Skip to content

crypto: re-add crypto.timingSafeEqual #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
not-an-aardvark wants to merge 16 commits into from
Closed

crypto: re-add crypto.timingSafeEqual #8304

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
627cbc0
Revert "Revert "crypto: add crypto.timingSafeEqual""
not-an-aardvark Aug 24, 2016
7e9869a
test: fix timing flake for crypto.timingSafeEqual
not-an-aardvark Aug 27, 2016
ca0e08a
squash: temporarily log detailed results if test fails
not-an-aardvark Aug 28, 2016
03ff774
squash: flip the order of the benchmarks
not-an-aardvark Aug 28, 2016
0c2077c
squash: change the order of the benchmarks every iteration
not-an-aardvark Aug 28, 2016
872e563
squash: split into two benchmark functions
not-an-aardvark Aug 28, 2016
e484b5f
squash: remove temporary logging
not-an-aardvark Aug 28, 2016
7d60f75
squash: add some eval()
not-an-aardvark Sep 1, 2016
f901e32
squash: never mind about eval()
not-an-aardvark Sep 1, 2016
5a36833
squash: use memory very inefficiently
not-an-aardvark Sep 1, 2016
9a0bba2
squash: update t-threshold for 1/10000 failure rate
not-an-aardvark Sep 2, 2016
bcee4a8
squash: allocate everything before benchmarking
not-an-aardvark Sep 2, 2016
240e8ac
squash: change the order of the benchmarks every iteration (take 2)
not-an-aardvark Sep 2, 2016
d810e06
squash: alternate the allocation order too
not-an-aardvark Sep 2, 2016
5a6f19e
squash: add note to docs about ensuring timing-safety
not-an-aardvark Sep 3, 2016
3c5ba3c
squash: add linebreaks in docs
not-an-aardvark Sep 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: split into two benchmark functions
  • Loading branch information
@not-an-aardvark
not-an-aardvark committed Aug 28, 2016
commit 872e56341170fafc4f8a9708ad66dc29c074f25c
34 changes: 18 additions & 16 deletions test/sequential/test-crypto-timing-safe-equal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,25 @@ assert.throws(function() {
crypto.timingSafeEqual(Buffer.from([1, 2]), 'not a buffer');
}, 'should throw if the second argument is not a buffer');

function runBenchmark(compareFunc, bufferA, bufferB, expectedResult) {
function runEqualBenchmark(compareFunc, bufferA, bufferB) {
const startTime = process.hrtime();
const result = compareFunc(bufferA, bufferB);
const endTime = process.hrtime(startTime);

// Ensure that the result of the function call gets used, so that it doesn't
// get discarded due to engine optimizations.
assert.strictEqual(result, expectedResult);
assert.strictEqual(result, true);
return endTime[0] * 1e9 + endTime[1];
}

// This is almost the same as the runEqualBenchmark function, but it's
// duplicated to avoid timing issues with V8 optimization/inlining.
function runUnequalBenchmark(compareFunc, bufferA, bufferB) {
const startTime = process.hrtime();
const result = compareFunc(bufferA, bufferB);
const endTime = process.hrtime(startTime);

assert.strictEqual(result, false);
return endTime[0] * 1e9 + endTime[1];
}

Expand All @@ -57,17 +68,10 @@ function getTValue(compareFunc) {
const rawUnequalBenches = Array(numTrials);

for (let i = 0; i < numTrials; i++) {

if (i % 2) {
// First benchmark: comparing two equal buffers
rawEqualBenches[i] = runBenchmark(compareFunc, bufferA1, bufferA2, true);
// Second benchmark: comparing two unequal buffers
rawUnequalBenches[i] = runBenchmark(compareFunc, bufferB, bufferC, false);
} else {
// Flip the order of the benchmarks every other iteration
rawUnequalBenches[i] = runBenchmark(compareFunc, bufferB, bufferC, false);
rawEqualBenches[i] = runBenchmark(compareFunc, bufferA1, bufferA2, true);
}
// First benchmark: comparing two equal buffers
rawEqualBenches[i] = runEqualBenchmark(compareFunc, bufferA1, bufferA2);
// Second benchmark: comparing two unequal buffers
rawUnequalBenches[i] = runUnequalBenchmark(compareFunc, bufferB, bufferC);
}

const equalBenches = filterOutliers(rawEqualBenches);
Expand Down Expand Up @@ -99,9 +103,7 @@ function getTValue(compareFunc) {
unequalStd: standardDeviation(unequalBenches),
combinedStd,
standardErr,
t: (equalMean - unequalMean) / standardErr,
rawEqualBenches: JSON.stringify(rawEqualBenches),
rawUnequalBenches: JSON.stringify(rawUnequalBenches)
t: (equalMean - unequalMean) / standardErr
});
}

Expand Down