Skip to content

crypto: re-add crypto.timingSafeEqual #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
not-an-aardvark wants to merge 16 commits into from
+199 −0
Closed

crypto: re-add crypto.timingSafeEqual #8304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
627cbc0
Revert "Revert "crypto: add crypto.timingSafeEqual""
not-an-aardvark Aug 24, 2016
7e9869a
test: fix timing flake for crypto.timingSafeEqual
not-an-aardvark Aug 27, 2016
ca0e08a
squash: temporarily log detailed results if test fails
not-an-aardvark Aug 28, 2016
03ff774
squash: flip the order of the benchmarks
not-an-aardvark Aug 28, 2016
0c2077c
squash: change the order of the benchmarks every iteration
not-an-aardvark Aug 28, 2016
872e563
squash: split into two benchmark functions
not-an-aardvark Aug 28, 2016
e484b5f
squash: remove temporary logging
not-an-aardvark Aug 28, 2016
7d60f75
squash: add some eval()
not-an-aardvark Sep 1, 2016
f901e32
squash: never mind about eval()
not-an-aardvark Sep 1, 2016
5a36833
squash: use memory very inefficiently
not-an-aardvark Sep 1, 2016
9a0bba2
squash: update t-threshold for 1/10000 failure rate
not-an-aardvark Sep 2, 2016
bcee4a8
squash: allocate everything before benchmarking
not-an-aardvark Sep 2, 2016
240e8ac
squash: change the order of the benchmarks every iteration (take 2)
not-an-aardvark Sep 2, 2016
d810e06
squash: alternate the allocation order too
not-an-aardvark Sep 2, 2016
5a6f19e
squash: add note to docs about ensuring timing-safety
not-an-aardvark Sep 3, 2016
3c5ba3c
squash: add linebreaks in docs
not-an-aardvark Sep 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix timing flake for crypto.timingSafeEqual
  • Loading branch information
@not-an-aardvark
not-an-aardvark committed Aug 27, 2016
commit 7e9869aa74587211355b73efd34663069fa04af1
5 changes: 0 additions & 5 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ prefix sequential

[true] # This section applies to all platforms

# crypto.timingSafeEqual contains a statistical timing test to verify that the
# function is timing-safe. As a result, the test sometimes fails due to random
# timing fluctuations.
test-crypto-timing-safe-equal : PASS,FLAKY

[$system==win32]

[$system==linux]
Expand Down
6 changes: 0 additions & 6 deletions test/sequential/test-crypto-timing-safe-equal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Flags: --allow_natives_syntax
'use strict';
const common = require('../common');
const assert = require('assert');
Expand Down Expand Up @@ -111,11 +110,6 @@ function filterOutliers(array) {
return array.filter((value) => value / arrMean < 50);
}

// Force optimization before starting the benchmark
runBenchmark(crypto.timingSafeEqual, Buffer.from('A'), Buffer.from('A'), true);
eval('%OptimizeFunctionOnNextCall(runBenchmark)');
runBenchmark(crypto.timingSafeEqual, Buffer.from('A'), Buffer.from('A'), true);

// t_(0.9995, ∞)
// i.e. If a given comparison function is indeed timing-safe, the t-test result
// has a 99.9% chance to be below this threshold. Unfortunately, this means that
Expand Down