Repository navigation
[v24.x backport] src: mark config file as stable - #66830
Open
marco-ippolito wants to merge 8 commits into
Open
marco-ippolito wants to merge 8 commits into
marco-ippolito wants to merge 8 commits into
Conversation
PR-URL: nodejs#60798 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: nodejs#60798 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: nodejs#63033 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: nodejs#64516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Collaborator
|
Review requested:
|
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: nodejs#66431 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: nodejs#66431 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#66559 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Regenerate the schema with tools/doc/generate-json-schema.mjs. It had fallen out of date because test-config-json-schema is skipped unless Node.js is built with QUIC, so it does not run in CI. Assisted-by: claude:opus-5.5 Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
force-pushed
the
backport-config-file-stable-v24.x
branch
from
October 18, 2026 13:37
65a0379 to
7558f48
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #66830 +/- ##
=================================================
- Coverage 90.31% 90.26% -0.06%
=================================================
Files 711 718 +7
Lines 228425 238227 +9802
Branches 43160 45274 +2114
=================================================
+ Hits 206293 215024 +8731
- Misses 14090 14703 +613
- Partials 8042 8500 +458
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the config file changes from v26.x that are missing on v24.x, to bring it to feature parity, including marking it as stable.
Original PRs:
src: add permission flag to config file,src: implicitly enable namespace in config)src: support multiple versions in node.config.json)Notes on the backport:
main, as the one on v26.x is incomplete (it is missing the change that copies the permission flags from the config file, and the test). The--allow-envhandling is left out, as it is not on v24.x.doc: fix webstorage config file property( src: implicitly enable namespace in config #60798) is not included, as v24.x already has that fix.node:benchis not on v24.x, so its changes in src: mark config file as stable #66431 are dropped.test-config-file, "should parse boolean flag" checks that there is no config file warning instead of an empty stderr, as--experimental-transform-typesstill emits its own warning on v24.x.doc/node.1is updated by hand, as it is not generated on v24.x.doc/node-config-schema.json, which was out of date on v24.x becausetest-config-json-schemais skipped unless Node.js is built with QUIC (see test: run test-config-json-schema in default builds #66827).