Repository navigation
test: run test-config-json-schema in default builds - #66827
Open
marco-ippolito wants to merge 2 commits into
Open
marco-ippolito wants to merge 2 commits into
marco-ippolito wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
Regenerate the schema with tools/doc/generate-json-schema.mjs. It had fallen out of date because test-config-json-schema was not running in CI. Assisted-by: claude:opus-5.5 Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
The test was skipped unless Node.js was built with QUIC, but the JSON schema is generated from a build with the default configuration options, where QUIC is disabled. As a result the test never ran in CI and the schema was no longer checked. Skip the test instead when QUIC, DTLS or the V8 sandbox are enabled, or when FFI is disabled, since each of these changes the set of available options. Also remove the check for the `node_quic` variable, which no longer exists. Compare the schemas with assert.deepStrictEqual() so that a failure shows which options differ instead of two long strings. Assisted-by: claude:opus-5.5 Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66827 +/- ##
==========================================
+ Coverage 90.50% 90.57% +0.07%
==========================================
Files 797 797
Lines 277793 277793
Branches 53366 53373 +7
==========================================
+ Hits 251405 251609 +204
+ Misses 16801 16561 -240
- Partials 9587 9623 +36 🚀 New features to boost your workflow:
|
marco-ippolito
force-pushed
the
test-config-json-schema-quic
branch
from
October 18, 2026 11:48
d51f626 to
8ac821e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-config-json-schemawas skipped unless Node.js was built with QUIC, butdoc/node-config-schema.jsonis generated from a default build, where QUIC is disabled. So the test never ran in CI and the schema was no longer checked.This skips the test instead when QUIC, DTLS or the V8 sandbox are enabled, or when FFI is disabled, since each of these changes the set of available options. It also removes the dead
node_quiccheck, and compares the schemas withassert.deepStrictEqual()so a failure shows which options differ.The schema had drifted in the meantime, so this also regenerates it with
tools/doc/generate-json-schema.mjs.