buffer: normalize lone "\r" in Blob native line endings#64115
Open
watilde wants to merge 1 commit into
Open
Conversation
`new Blob(parts, { endings: 'native' })` failed to normalize a
standalone carriage return. The replacement regex only matched
`\n` and `\r\n`, so a lone `\r` (and runs such as `\r\r`) were
left untouched instead of being converted to the platform's
native line ending.
The WHATWG "convert line endings to native" algorithm requires
`\r`, `\n`, and `\r\n` to all be normalized. Match `\r\n` before
a lone `\r` so that CRLF collapses to a single native ending.
Refs: https://w3c.github.io/FileAPI/#convert-line-endings-to-native
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new Blob(parts, { endings: 'native' })failed to normalize a standalone carriage return. The replacement regex only matched\nand\r\n, so a lone\r(and runs such as\r\r) were left untouched instead of being converted to the platform's native line ending.The WHATWG "convert line endings to native" algorithm requires
\r,\n, and\r\nto all be normalized. Match\r\nbefore a lone\rso that CRLF collapses to a single native ending.Refs: https://w3c.github.io/FileAPI/#convert-line-endings-to-native