Skip to content

net: stable blocklist#63050

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
skunksworks:main
Jun 2, 2026
Merged

net: stable blocklist#63050
aduh95 merged 1 commit into
nodejs:mainfrom
skunksworks:main

Conversation

@alphaleadership

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 30, 2026
@Ethan-Arrowood

Copy link
Copy Markdown
Contributor

This is not how we promote a feature status.

@alphaleadership

Copy link
Copy Markdown
Contributor Author

and what is the good method

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor

Look back on the history of the feature and tag the contributors / teams responsible for it in an issue or in Slack. Coordinate with them on the correct version this can be promoted to be stable in and go from there. In this case I don't think there are any necessary API changes. And then likely this should be marked as "1.2 Release Candidate" per the stabilty index: https://nodejs.org/docs/latest/api/documentation.html#stability-index

@alphaleadership

alphaleadership commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

@Ethan-Arrowood status corrected

@alphaleadership

Copy link
Copy Markdown
Contributor Author

@Ethan-Arrowood

Signed-off-by: arbinger <alphaleadershipyt@protonmail.com>
@alphaleadership

Copy link
Copy Markdown
Contributor Author

can this be merged

@jasnell jasnell added semver-minor PRs that contain new features and should be released in the next minor version. commit-queue Add this label to land a pull request using GitHub Actions. labels May 15, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63050
✔  Done loading data for nodejs/node/pull/63050
----------------------------------- PR info ------------------------------------
Title      net: stable blocklist (#63050)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     alphaleadership:main -> nodejs:main
Labels     semver-minor, needs-ci
Commits    1
 - doc: update blockList stability status to release candidate
Committers 1
 - arbinger <alphaleadershipyt@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/63050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 30 Apr 2026 13:57:33 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63050#pullrequestreview-4272409611
   ✔  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/63050#pullrequestreview-4299444860
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/25945525214

@alphaleadership

alphaleadership commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

Commit Queue failed


ℹ This PR was created on Thu, 30 Apr 2026 13:57:33 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): #63050 (review)
✔ - Ethan Arrowood (@Ethan-Arrowood): #63050 (review)
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected

✔ Aborted git node land session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/25945525214

not need

@Ethan-Arrowood

Copy link
Copy Markdown
Contributor

Please self-moderate your previous comment to respect the Node.js Code of Conduct. Thank you.

@Ethan-Arrowood Ethan-Arrowood added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 17, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@alphaleadership

Copy link
Copy Markdown
Contributor Author

Need a New ci

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jun 2, 2026
@aduh95 aduh95 merged commit 60dab8d into nodejs:main Jun 2, 2026
55 of 59 checks passed
@aduh95

aduh95 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Landed in 60dab8d

aduh95 pushed a commit that referenced this pull request Jun 18, 2026
Signed-off-by: arbinger <alphaleadershipyt@protonmail.com>
PR-URL: #63050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
nodejs-github-bot added a commit that referenced this pull request Jun 22, 2026
Notable changes:

build, doc:
  * generate node.1 with doc-kit (Aviv Keller) #62044
deps:
  * (SEMVER-MINOR) update OpenSSL build config to support compression (Tim Perry) #62217
doc:
  * (SEMVER-MINOR) update `blockList` stability status to release candidate (alphaleadership) #63050
fs:
  * (SEMVER-MINOR) support caller-supplied readFile() buffers (Matteo Collina) #63634
http:
  * (SEMVER-MINOR) close pre-request sockets in closeIdleConnections (semimikoh) #63470
loader:
  * (SEMVER-MINOR) implement package maps (Maël Nison) #62239
net:
  * (SEMVER-MINOR) support TCP_KEEPINTVL and TCP_KEEPCNT in setKeepAlive (Guy Bedford) #63825
tls:
  * (SEMVER-MINOR) add certificateCompression option (Tim Perry) #62217
vfs:
  * (SEMVER-MINOR) dispatch fs/promises to mounted VFS instances (Matteo Collina) #63537
  * (SEMVER-MINOR) add minimal node:vfs subsystem (Matteo Collina) #63115

PR-URL: #64058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants