tools: add lint rule for aborted AbortController#63541
Open
trivikr wants to merge 1 commit into
Open
Conversation
Refs: nodejs#63489 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63541 +/- ##
==========================================
+ Coverage 90.31% 90.33% +0.01%
==========================================
Files 730 730
Lines 234152 234152
Branches 43913 43917 +4
==========================================
+ Hits 211482 211527 +45
+ Misses 14381 14356 -25
+ Partials 8289 8269 -20 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an ESLint rule to prefer
AbortSignal.abort()when a test creates anAbortController, immediately aborts it, and only uses the resultingcontroller.signal.The rule is intentionally conservative and only fixes the simple already-aborted
signal pattern from #63489.
The rule uses ESLint scope analysis rather than text matching. After finding a
candidate declaration, it gets the declared variable with
sourceCode.scopeManager.getDeclaredVariables()and checks all references tothat variable.
It only reports when the variable has exactly two non-declaration references:
controller.abort()callcontroller.signalreadIf the controller is logged, passed somewhere else, aborted later, read more than
once, or otherwise referenced, the rule does not report or autofix it.
Assisted-by: openai:gpt-5.5