test: get rid of unnecessary AbortController instanciations#63489
Open
aduh95 wants to merge 1 commit into
Open
test: get rid of unnecessary AbortController instanciations#63489aduh95 wants to merge 1 commit into
AbortController instanciations#63489aduh95 wants to merge 1 commit into
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63489 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 718 718
Lines 227914 227914
Branches 42811 42812 +1
=======================================
+ Hits 205435 205437 +2
+ Misses 14248 14244 -4
- Partials 8231 8233 +2 🚀 New features to boost your workflow:
|
avivkeller
approved these changes
May 22, 2026
legendecas
approved these changes
May 22, 2026
Collaborator
Renegade334
approved these changes
May 22, 2026
trivikr
approved these changes
May 22, 2026
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've considered doing a lint rule, but the effort to verify if the controller is used elsewhere makes it probably not worth it.