Skip to content

[v20.x backport] src: move package_json_reader cache to c++ #56590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 6 commits into from
Closed

[v20.x backport] src: move package_json_reader cache to c++ #56590

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7845d55
deps: add simdjson
anonrig Oct 21, 2023
6e50795
src: move package resolver to c++
anonrig Oct 25, 2023
1b5abae
module: merge config with `package_json_reader`
anonrig Nov 10, 2023
f78b464
fixup! deps: add simdjson
joyeecheung Jan 14, 2025
5f9c573
fixup! src: move package resolver to c++
joyeecheung Jan 14, 2025
7c94000
fixup! src: move package resolver to c++
joyeecheung Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! deps: add simdjson
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 14, 2025
commit f78b46495117c708cc3f1dc47c2dc99fb6bf4023
12 changes: 10 additions & 2 deletions deps/simdjson/simdjson.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16560,8 +16560,12 @@ class json_iterator {
*
* - increment_count(iter) - each time a value is found in an array or object.
*/
/**
* To backport simdjson to Node.js v20.x which uses gnu++17, this is patched to use inline
* instead of always_inline to avoid forcing GCC to inline it on platforms that don't support it.
*/
template<bool STREAMING, typename V>
simdjson_warn_unused simdjson_inline error_code walk_document(V &visitor) noexcept;
simdjson_warn_unused inline error_code walk_document(V &visitor) noexcept;

/**
* Create an iterator capable of walking a JSON document.
Expand Down Expand Up @@ -16633,8 +16637,12 @@ class json_iterator {
simdjson_warn_unused simdjson_inline error_code visit_primitive(V &visitor, const uint8_t *value) noexcept;
};

/**
* To backport simdjson to Node.js v20.x which uses gnu++17, this is patched to use inline
* instead of always_inline to avoid forcing GCC to inline it on platforms that don't support it.
*/
template<bool STREAMING, typename V>
simdjson_warn_unused simdjson_inline error_code json_iterator::walk_document(V &visitor) noexcept {
simdjson_warn_unused inline error_code json_iterator::walk_document(V &visitor) noexcept {
logger::log_start();

//
Expand Down