Skip to content

[v20.x backport] src: move package_json_reader cache to c++ #56590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 6 commits into from
Closed

[v20.x backport] src: move package_json_reader cache to c++ #56590

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7845d55
deps: add simdjson
anonrig Oct 21, 2023
6e50795
src: move package resolver to c++
anonrig Oct 25, 2023
1b5abae
module: merge config with `package_json_reader`
anonrig Nov 10, 2023
f78b464
fixup! deps: add simdjson
joyeecheung Jan 14, 2025
5f9c573
fixup! src: move package resolver to c++
joyeecheung Jan 14, 2025
7c94000
fixup! src: move package resolver to c++
joyeecheung Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: move package resolver to c++
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 15, 2025
commit 7c940005374d4915662149d8478c940413cb248b
20 changes: 20 additions & 0 deletions src/node_modules.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,26 @@ const BindingData::PackageConfig* BindingData::GetPackageJSON(

PackageConfig package_config{};
package_config.file_path = path;

#ifdef _AIX
// On AIX, the file read can still succeed even if it's a directory.
// For backporting https://github.com/nodejs/node/pull/50322 to v20.x,
// add the special case back and return early to notify the JS land
// and let it treat it as if the package.json does not exist.
// See https://github.com/libuv/libuv/pull/2025 and
// https://github.com/nodejs/node/pull/48477#issuecomment-1604586650
uv_fs_t req;
int rc = uv_fs_stat(nullptr, &req, path.data(), nullptr);
if (rc == 0) {
const uv_stat_t* const s = static_cast<const uv_stat_t*>(req.ptr);
bool is_dir = ((s->st_mode & S_IFMT) == S_IFDIR);
uv_fs_req_cleanup(&req);
if (is_dir) {
return nullptr;
}
}
#endif

// No need to exclude BOM since simdjson will skip it.
if (ReadFileSync(&package_config.raw_json, path.data()) < 0) {
return nullptr;
Expand Down