fixup! fixup! src: make BuiltinLoader threadsafe and non-global

nodejs · nodejs-github-bot · Jan 18, 2023 · Dec 22, 2022 · Jan 6, 2023 · Jan 6, 2023
commit 1bfd5acc4af1b374db6792a65a5808aeb76e345e
diff --git a/src/node.cc b/src/node.cc
@@ -126,8 +126,6 @@
 
 namespace node {
 
-using builtins::BuiltinLoader;
-
 using v8::EscapableHandleScope;
 using v8::Isolate;
 using v8::Local;

diff --git a/src/node_realm.cc b/src/node_realm.cc
@@ -8,7 +8,6 @@
 
 namespace node {
 
-using builtins::BuiltinLoader;
 using v8::Context;
 using v8::EscapableHandleScope;
 using v8::Function;

diff --git a/src/node_threadsafe_cow.h b/src/node_threadsafe_cow.h
@@ -80,8 +80,8 @@ class ThreadsafeCopyOnWrite final {
 
  private:
   struct Impl {
-    Impl(const T& data) : data(data) {}
-    Impl(T&& data) : data(std::move(data)) {}
+    explicit Impl(const T& data) : data(data) {}
+    explicit Impl(T&& data) : data(std::move(data)) {}
 
     Impl(const Impl& other);
     Impl& operator=(const Impl& other) = delete;