Skip to content

test_runner: support using --inspect with --test #44520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 15 commits into from
Sep 10, 2022
Merged

test_runner: support using --inspect with --test #44520

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ae799bd
test_runner: support using `--inspect` with `--test`
MoLow Sep 5, 2022
9414d24
CR & tests
MoLow Sep 6, 2022
2e344c3
CR
MoLow Sep 6, 2022
d1fdf1c
CR
MoLow Sep 8, 2022
572ad0d
fixes
MoLow Sep 8, 2022
dea4784
Apply suggestions from code review
MoLow Sep 8, 2022
85b5716
Update lib/internal/cluster/primary.js
MoLow Sep 8, 2022
a762de7
attampt fixing windows build
MoLow Sep 8, 2022
1da1d5e
try fully sequential
MoLow Sep 8, 2022
c1a956c
lint
MoLow Sep 8, 2022
e137527
try debugging this
MoLow Sep 8, 2022
3346b00
try
MoLow Sep 8, 2022
92ea9bb
fix
MoLow Sep 9, 2022
b07d574
primordials
MoLow Sep 9, 2022
2e1c14a
optimize
MoLow Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CR
  • Loading branch information
@MoLow
MoLow committed Sep 6, 2022
commit 2e344c3989d3a579b26cea61d2aa8f014750655c
88 changes: 57 additions & 31 deletions test/sequential/test-runner-run-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,27 @@ const childProcess = require('child_process');
const { values: { 'top-level': isTopLevel } } =
parseArgs({ options: { topLevel: { type: 'boolean' } }, strict: false });

async function spawnRunner({ execArgv, expectedPort, expectedHost, expectedInitialPort, inspectPort }) {
const { code, signal } = await new Promise((resolve) => {
childProcess.spawn(process.execPath,
Comment thread
MoLow marked this conversation as resolved.
Outdated
['--expose-internals', '--no-warnings', ...execArgv, __filename, '--top-level'], {
env: { ...process.env,
expectedPort: JSON.stringify(expectedPort),
inspectPort,
expectedHost,
expectedInitialPort,
testProcess: true },
stdio: 'inherit',
}).on('exit', (code, signal) => resolve({ code, signal }));
});
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
}

let offset = 0;

async function testRunnerMain() {
await spawnRunner({
const defaultPortCase = spawnRunner({
execArgv: ['--inspect'],
expectedPort: 9230,
});
Expand Down Expand Up @@ -51,29 +68,29 @@ async function testRunnerMain() {

await spawnRunner({
execArgv: [`--inspect=0.0.0.0:${port}`],
expectedPort: port + 1
expectedPort: port + 1, expectedHost: '0.0.0.0',
});

port = debuggerPort + offset++ * 5;

await spawnRunner({
execArgv: [`--inspect=127.0.0.1:${port}`],
expectedPort: port + 1
expectedPort: port + 1, expectedHost: '127.0.0.1'
});

if (common.hasIPv6) {
port = debuggerPort + offset++ * 5;

await spawnRunner({
execArgv: [`--inspect=[::]:${port}`],
expectedPort: port + 1
expectedPort: port + 1, expectedHost: '::'
});

port = debuggerPort + offset++ * 5;

await spawnRunner({
execArgv: [`--inspect=[::1]:${port}`],
expectedPort: port + 1
expectedPort: port + 1, expectedHost: '::1'
});
}

Expand Down Expand Up @@ -134,12 +151,30 @@ async function testRunnerMain() {

port = debuggerPort + offset++ * 5;

spawnRunner({
await spawnRunner({
execArgv: [`--inspect=${port}`],
inspectPort: 'strfunc',
});

port = debuggerPort + offset++ * 5;

await spawnRunner({
execArgv: [`--inspect=${port}`],
inspectPort: 0,
expectedInitialPort: 0,
});

await defaultPortCase;

port = debuggerPort + offset++ * 5;
await spawnRunner({
execArgv: ['--inspect'],
inspectPort: port + 2,
expectedInitialPort: port + 2,
});
}

const badPortError = { name: 'RangeError', code: 'ERR_SOCKET_BAD_PORT' };
function runTest() {
const { run } = require('node:test');
let inspectPort = 'inspectPort' in process.env ? Number(process.env.inspectPort) : undefined;
Expand All @@ -149,21 +184,21 @@ function runTest() {
inspectPort = common.mustCall(() => { return process.debugPort += 2; });
} else if (process.env.inspectPort === 'string') {
inspectPort = 'string';
expectedError = { name: 'RangeError', code: 'ERR_SOCKET_BAD_PORT' };
expectedError = badPortError;
} else if (process.env.inspectPort === 'null') {
inspectPort = null;
} else if (process.env.inspectPort === 'bignumber') {
inspectPort = 1293812;
expectedError = { name: 'RangeError', code: 'ERR_SOCKET_BAD_PORT' };
expectedError = badPortError;
} else if (process.env.inspectPort === 'negativenumber') {
inspectPort = -9776;
expectedError = { name: 'RangeError', code: 'ERR_SOCKET_BAD_PORT' };
expectedError = badPortError;
} else if (process.env.inspectPort === 'bignumberfunc') {
inspectPort = common.mustCall(() => 123121);
expectedError = { name: 'RangeError', code: 'ERR_SOCKET_BAD_PORT' };
expectedError = badPortError;
} else if (process.env.inspectPort === 'strfunc') {
inspectPort = common.mustCall(() => 'invalidPort');
expectedError = { name: 'RangeError', code: 'ERR_SOCKET_BAD_PORT' };
expectedError = badPortError;
}

const stream = run({ files: [__filename], inspectPort });
Expand All @@ -178,31 +213,22 @@ function runTest() {


function assertParams() {
const { expectedPort } = process.env;
const { expectedPort, expectedInitialPort, expectedHost } = process.env;
const debugOptions =
require('internal/options').getOptionValue('--inspect-port');

if ('expectedPort' in process.env) {
assert.strictEqual(process.debugPort, +expectedPort);
}
process.exit();
}

function spawnRunner({ execArgv, expectedPort, inspectPort }) {
return new Promise((resolve) => {
childProcess.spawn(process.execPath, ['--no-warnings', ...execArgv, __filename, '--top-level'], {
env: { ...process.env,
expectedPort: JSON.stringify(expectedPort),
inspectPort,
testProcess: true },
stdio: 'inherit',
}).on('exit', common.mustCall((code, signal) => {
checkExitCode(code, signal);
resolve();
}));
});
}
if ('expectedInitialPort' in process.env) {
assert.strictEqual(debugOptions.port, +expectedInitialPort);
}

function checkExitCode(code, signal) {
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
if ('expectedHost' in process.env) {
assert.strictEqual(debugOptions.host, expectedHost);
}
process.exit();
}

if (!process.env.testProcess && !isTopLevel) {
Expand Down