Skip to content

test_runner: support using --inspect with --test #44520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 15 commits into from
Sep 10, 2022
Merged

test_runner: support using --inspect with --test #44520

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ae799bd
test_runner: support using `--inspect` with `--test`
MoLow Sep 5, 2022
9414d24
CR & tests
MoLow Sep 6, 2022
2e344c3
CR
MoLow Sep 6, 2022
d1fdf1c
CR
MoLow Sep 8, 2022
572ad0d
fixes
MoLow Sep 8, 2022
dea4784
Apply suggestions from code review
MoLow Sep 8, 2022
85b5716
Update lib/internal/cluster/primary.js
MoLow Sep 8, 2022
a762de7
attampt fixing windows build
MoLow Sep 8, 2022
1da1d5e
try fully sequential
MoLow Sep 8, 2022
c1a956c
lint
MoLow Sep 8, 2022
e137527
try debugging this
MoLow Sep 8, 2022
3346b00
try
MoLow Sep 8, 2022
92ea9bb
fix
MoLow Sep 9, 2022
b07d574
primordials
MoLow Sep 9, 2022
2e1c14a
optimize
MoLow Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try fully sequential
  • Loading branch information
@MoLow
MoLow committed Sep 8, 2022
commit 1da1d5ed1e0d5db12893946351246c4964fc61c9
47 changes: 17 additions & 30 deletions test/sequential/test-runner-inspect.js → test/sequential/test-runner-inspect.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
'use strict';
const common = require('../common');
const tmpdir = require('../common/tmpdir.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');
const { spawnSync } = require('child_process');
const { join } = require('path');
const fixtures = require('../common/fixtures');
const testFixtures = fixtures.path('test-runner');
import * as common from '../common/index.mjs';
import * as tmpdir from '../common/tmpdir.js';
import * as fixtures from '../common/fixtures.mjs';
import assert from 'node:assert';
import { NodeInstance } from '../common/inspector-helper.js';


common.skipIfInspectorDisabled();
tmpdir.refresh();

async function debugTest() {
const child = new NodeInstance(['--test', '--inspect-brk=0'], undefined, join(testFixtures, 'index.test.js'));
{
const child = new NodeInstance(['--test', '--inspect-brk=0'], undefined, fixtures.path('test-runner/index.test.js'));

let stdout = '';
let stderr = '';
Expand All @@ -23,46 +21,35 @@ async function debugTest() {

await session.send([
{ method: 'Runtime.enable' },
{ method: 'NodeRuntime.notifyWhenWaitingForDisconnect',
params: { enabled: true } },
{ method: 'Runtime.runIfWaitingForDebugger' }]);


await session.waitForNotification((notification) => {
return notification.method === 'NodeRuntime.waitingForDisconnect';
});

session.disconnect();
assert.match(stderr,
/Warning: Using the inspector with --test forces running at a concurrency of 1\. Use the inspectPort option to run with concurrency/);
}

debugTest().then(common.mustCall());


{
const args = ['--test', '--inspect=0', join(testFixtures, 'index.js')];
const child = spawnSync(process.execPath, args);
const args = ['--test', '--inspect=0', fixtures.path('test-runner/index.js')];
const { stderr, stdout, code, signal } = await common.spawnPromisified(process.execPath, args);

assert.match(child.stderr.toString(),
assert.match(stderr,
/Warning: Using the inspector with --test forces running at a concurrency of 1\. Use the inspectPort option to run with concurrency/);
const stdout = child.stdout.toString();
assert.match(stdout, /not ok 1 - .+index\.js/);
assert.match(stdout, /stderr: \|-\r?\n\s+Debugger listening on/);
assert.strictEqual(child.status, 1);
assert.strictEqual(child.signal, null);
assert.strictEqual(code, 1);
assert.strictEqual(signal, null);
}


{
// File not found.
const args = ['--test', '--inspect=0', 'a-random-file-that-does-not-exist.js'];
const child = spawnSync(process.execPath, args);
const { stderr, stdout, code, signal } = await common.spawnPromisified(process.execPath, args);

const stderr = child.stderr.toString();
assert.strictEqual(child.stdout.toString(), '');
assert.strictEqual(stdout, '');
assert.match(stderr, /^Could not find/);
assert.doesNotMatch(stderr, /Warning: Using the inspector with --test forces running at a concurrency of 1\. Use the inspectPort option to run with concurrency/);
assert.strictEqual(child.status, 1);
assert.strictEqual(child.signal, null);
assert.strictEqual(code, 1);
assert.strictEqual(signal, null);
}