Skip to content

[16.x backport] tools: enable no-empty ESLint rule #42160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 8 commits into from
Closed

[16.x backport] tools: enable no-empty ESLint rule #42160

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf3bb92
benchmark: enable no-empty ESLint rule
Trott Feb 3, 2022
a24b61a
doc: remove empty block from console.timeEnd() example
Trott Feb 3, 2022
7c0cd14
doc: add comments to empty blocks in worker_threads text
Trott Feb 3, 2022
0038697
lib: add comments to empty catch statements
Trott Feb 3, 2022
b35692f
policy: revise manifest.js to avoid empty blocks
Trott Feb 3, 2022
d00c97a
stream: remove empty block
Trott Feb 3, 2022
48f5a12
test: enable no-empty ESLint rule
Trott Feb 3, 2022
01c3818
tools: enable no-empty ESLint rule
Trott Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stream: remove empty block 
PR-URL: #41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@Trott
Trott committed Mar 2, 2022
commit d00c97a393172228f1c953510c60248434c2b064
2 changes: 1 addition & 1 deletion lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,7 @@ function readableStreamPipeTo(

async function run() {
// Run until step resolves as true
while (!await step()) {}
while (!await step());
}

if (signal !== undefined) {
Expand Down