benchmark: enable no-empty ESLint rule

PR-URL: #41831 Refs: https://eslint.org/docs/rules/no-empty Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs · Trott · Feb 3, 2022 · Feb 3, 2022 · Feb 3, 2022 · Feb 3, 2022
commit bf3bb929bf4ab7f2e1fc818f5901002c819ede90
diff --git a/benchmark/.eslintrc.yaml b/benchmark/.eslintrc.yaml
@@ -5,5 +5,6 @@ env:
   es6: true
 
 rules:
+  no-empty: error
   no-var: error
   prefer-arrow-callback: error
diff --git a/benchmark/es/foreach-bench.js b/benchmark/es/foreach-bench.js
@@ -22,7 +22,7 @@ function useFor(n, items, count) {
 function useForOf(n, items) {
   bench.start();
   for (let i = 0; i < n; i++) {
-    // eslint-disable-next-line no-unused-vars
+    // eslint-disable-next-line no-unused-vars, no-empty
     for (const item of items) {}
   }
   bench.end(n);

diff --git a/benchmark/fs/bench-statSync-failure.js b/benchmark/fs/bench-statSync-failure.js
@@ -21,6 +21,7 @@ function main({ n, statSyncType }) {
       try {
         fs.statSync(arg);
       } catch {
+        // Continue regardless of error.
       }
     }
   }

diff --git a/benchmark/fs/read-stream-throughput.js b/benchmark/fs/read-stream-throughput.js
@@ -50,7 +50,11 @@ function main(conf) {
     buf.fill('x');
   }
 
-  try { fs.unlinkSync(filename); } catch {}
+  try {
+    fs.unlinkSync(filename);
+  } catch {
+    // Continue regardless of error.
+  }
   const ws = fs.createWriteStream(filename);
   ws.on('close', runTest.bind(null, filesize, highWaterMark, encoding, n));
   ws.on('drain', write);
@@ -81,7 +85,11 @@ function runTest(filesize, highWaterMark, encoding, n) {
   });
 
   rs.on('end', () => {
-    try { fs.unlinkSync(filename); } catch {}
+    try {
+      fs.unlinkSync(filename);
+    } catch {
+      // Continue regardless of error.
+    }
     // MB/sec
     bench.end(bytes / (1024 * 1024));
   });

diff --git a/benchmark/fs/readfile-partitioned.js b/benchmark/fs/readfile-partitioned.js
@@ -23,7 +23,11 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ len, dur, concurrent }) {
-  try { fs.unlinkSync(filename); } catch {}
+  try {
+    fs.unlinkSync(filename);
+  } catch {
+    // Continue regardless of error.
+  }
   let data = Buffer.alloc(len, 'x');
   fs.writeFileSync(filename, data);
   data = null;
@@ -38,7 +42,11 @@ function main({ len, dur, concurrent }) {
     const totalOps = reads + zips;
     benchEnded = true;
     bench.end(totalOps);
-    try { fs.unlinkSync(filename); } catch {}
+    try {
+      fs.unlinkSync(filename);
+    } catch {
+      // Continue regardless of error.
+    }
   }, dur * 1000);
 
   function read() {

diff --git a/benchmark/fs/readfile-promises.js b/benchmark/fs/readfile-promises.js
@@ -20,7 +20,11 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ len, duration, concurrent }) {
-  try { fs.unlinkSync(filename); } catch { }
+  try {
+    fs.unlinkSync(filename);
+  } catch {
+    // Continue regardless of error.
+  }
   let data = Buffer.alloc(len, 'x');
   fs.writeFileSync(filename, data);
   data = null;
@@ -31,7 +35,11 @@ function main({ len, duration, concurrent }) {
   setTimeout(() => {
     benchEnded = true;
     bench.end(writes);
-    try { fs.unlinkSync(filename); } catch { }
+    try {
+      fs.unlinkSync(filename);
+    } catch {
+      // Continue regardless of error.
+    }
     process.exit(0);
   }, duration * 1000);
 

diff --git a/benchmark/fs/readfile.js b/benchmark/fs/readfile.js
@@ -20,7 +20,11 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ len, duration, concurrent }) {
-  try { fs.unlinkSync(filename); } catch {}
+  try {
+    fs.unlinkSync(filename);
+  } catch {
+    // Continue regardless of error.
+  }
   let data = Buffer.alloc(len, 'x');
   fs.writeFileSync(filename, data);
   data = null;
@@ -31,7 +35,11 @@ function main({ len, duration, concurrent }) {
   setTimeout(() => {
     benchEnded = true;
     bench.end(reads);
-    try { fs.unlinkSync(filename); } catch {}
+    try {
+      fs.unlinkSync(filename);
+    } catch {
+      // Continue regardless of error.
+    }
     process.exit(0);
   }, duration * 1000);
 

diff --git a/benchmark/fs/write-stream-throughput.js b/benchmark/fs/write-stream-throughput.js
@@ -36,7 +36,11 @@ function main({ dur, encodingType, size }) {
       throw new Error(`invalid encodingType: ${encodingType}`);
   }
 
-  try { fs.unlinkSync(filename); } catch {}
+  try {
+    fs.unlinkSync(filename);
+  } catch {
+    // Continue regardless of error.
+  }
 
   let started = false;
   let ended = false;
@@ -48,7 +52,11 @@ function main({ dur, encodingType, size }) {
   f.on('finish', () => {
     ended = true;
     const written = fs.statSync(filename).size / 1024;
-    try { fs.unlinkSync(filename); } catch {}
+    try {
+      fs.unlinkSync(filename);
+    } catch {
+      // Continue regardless of error.
+    }
     bench.end(written / 1024);
   });
 

diff --git a/benchmark/fs/writefile-promises.js b/benchmark/fs/writefile-promises.js
@@ -46,7 +46,11 @@ function main({ encodingType, duration, concurrent, size }) {
     benchEnded = true;
     bench.end(writes);
     for (let i = 0; i < filesWritten; i++) {
-      try { fs.unlinkSync(`${filename}-${i}`); } catch { }
+      try {
+        fs.unlinkSync(`${filename}-${i}`);
+      } catch {
+        // Continue regardless of error.
+      }
     }
     process.exit(0);
   }, duration * 1000);

diff --git a/benchmark/misc/punycode.js b/benchmark/misc/punycode.js
@@ -4,7 +4,9 @@ const common = require('../common.js');
 let icu;
 try {
   icu = common.binding('icu');
-} catch {}
+} catch {
+  // Continue regardless of error.
+}
 const punycode = require('punycode');
 
 const bench = common.createBenchmark(main, {

diff --git a/benchmark/net/net-c2s-cork.js b/benchmark/net/net-c2s-cork.js
@@ -55,7 +55,7 @@ function main({ dur, len, type }) {
 
       function send() {
         socket.cork();
-        while (socket.write(chunk, encoding)) {}
+        while (socket.write(chunk, encoding));
         socket.uncork();
       }
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,6 +21,7 @@ function main({ n, statSyncType }) { @@
           try {
             fs.statSync(arg);
           } catch {
+            // Continue regardless of error.
           }
         }
       }
@@ Expand Down @@