Skip to content

[v14.x backport] esm: make process.exit() default to exit code 0 #41508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 4 commits into from
Closed

[v14.x backport] esm: make process.exit() default to exit code 0 #41508

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
968960d
esm: make `process.exit()` default to exit code 0
MoonBall Jan 14, 2022
15e2f48
Update lib/internal/modules/esm/handle_process_exit.js
aduh95 Jan 14, 2022
0687cbe
fix tests
aduh95 Jan 14, 2022
8883b4c
fix linter
aduh95 Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/modules/esm/handle_process_exit.js 
Co-authored-by: Richard Lau <rlau@redhat.com>
  • Loading branch information
@aduh95 @richardlau
aduh95 and richardlau authored Jan 14, 2022
commit 15e2f48d67152cb097b56a10f71610d1a016f199
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/handle_process_exit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// In that case, it makes sense to set the exit code to a specific non-zero
// value if the main code never finishes running.
function handleProcessExit() {
process.exitCode ??= 13;
if (process.exitCode == null) process.exitCode = 13;
}

module.exports = {
Expand Down