Skip to content

[v14.x backport] esm: make process.exit() default to exit code 0 #41508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 4 commits into from
Closed

[v14.x backport] esm: make process.exit() default to exit code 0 #41508

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
968960d
esm: make `process.exit()` default to exit code 0
MoonBall Jan 14, 2022
15e2f48
Update lib/internal/modules/esm/handle_process_exit.js
aduh95 Jan 14, 2022
0687cbe
fix tests
aduh95 Jan 14, 2022
8883b4c
fix linter
aduh95 Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@aduh95
aduh95 committed Jan 14, 2022
commit 0687cbe53e68d100334eaaa8d29f8d31b891ee96
1 change: 1 addition & 0 deletions test/message/esm_display_syntax_error_import.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ SyntaxError: The requested module '../fixtures/es-module-loaders/module-named-ex
at async ModuleJob.run (internal/modules/esm/module_job.js:*:*)
at async Loader.import (internal/modules/esm/loader.js:*:*)
at async Object.loadESM (internal/process/esm_loader.js:*:*)
at async handleMainPromise (internal/modules/run_main.js:*:*)
1 change: 1 addition & 0 deletions test/message/esm_display_syntax_error_import_module.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ SyntaxError: The requested module './module-named-exports.mjs' does not provide
at async ModuleJob.run (internal/modules/esm/module_job.js:*:*)
at async Loader.import (internal/modules/esm/loader.js:*:*)
at async Object.loadESM (internal/process/esm_loader.js:*:*)
at async handleMainPromise (internal/modules/run_main.js:*:*)