Skip to content

module: process.exit() should result in exit code 0 #41388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 11 commits into from
Jan 14, 2022
Merged

module: process.exit() should result in exit code 0 #41388

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b828eac
module: `process.exit()` should result in exit code 0
MoonBall Jan 3, 2022
5ebf9b0
Update test/fixtures/es-modules/tla/unresolved-with-worker-process-ex…
MoonBall Jan 3, 2022
fab1eed
Update test/fixtures/es-modules/tla/process-exit.mjs
MoonBall Jan 3, 2022
4e6f2c0
Update lib/internal/modules/run_main.js
MoonBall Jan 3, 2022
dbf136c
Update lib/internal/process/per_thread.js
MoonBall Jan 3, 2022
24bc42c
Update test/fixtures/es-modules/tla/unresolved-with-worker-process-ex…
MoonBall Jan 3, 2022
adcf374
Update lib/internal/modules/esm/handle_process_exit.js
MoonBall Jan 3, 2022
73e0b71
use isMainThread
MoonBall Jan 4, 2022
d58b5b9
add `handle_process_exit` to bootstrap modules
MoonBall Jan 4, 2022
d7bb21f
move comment to handle_process_exit file
MoonBall Jan 4, 2022
0951516
Update lib/internal/modules/esm/handle_process_exit.js
MoonBall Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/process/per_thread.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@MoonBall @aduh95
MoonBall and aduh95 authored Jan 3, 2022
commit dbf136c542654674a456eb342af783ad126aad68
2 changes: 1 addition & 1 deletion lib/internal/process/per_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const {
const constants = internalBinding('constants').os.signals;

const {
handleProcessExit
handleProcessExit,
} = require('internal/modules/esm/handle_process_exit');
Copy link
Copy Markdown
Member

@GeoffreyBooth GeoffreyBooth Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this logic happens for all code, not just ESM code, should handle_process_exit.js be under modules/esm?

Copy link
Copy Markdown
Contributor

@aduh95 aduh95 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only happens for ESM code, because it's the only place we have TLA in Node.js.

Copy link
Copy Markdown
Member Author

@MoonBall MoonBall Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious what's the full name of TLA? 🤣

Copy link
Copy Markdown
Contributor

@aduh95 aduh95 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an acronym for Top Level Await, sorry I was too lazy to type it all out 🙈


const kInternal = Symbol('internal properties');
Expand Down