Skip to content

module: process.exit() should result in exit code 0 #41388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 11 commits into from
Jan 14, 2022
Merged

module: process.exit() should result in exit code 0 #41388

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b828eac
module: `process.exit()` should result in exit code 0
MoonBall Jan 3, 2022
5ebf9b0
Update test/fixtures/es-modules/tla/unresolved-with-worker-process-ex…
MoonBall Jan 3, 2022
fab1eed
Update test/fixtures/es-modules/tla/process-exit.mjs
MoonBall Jan 3, 2022
4e6f2c0
Update lib/internal/modules/run_main.js
MoonBall Jan 3, 2022
dbf136c
Update lib/internal/process/per_thread.js
MoonBall Jan 3, 2022
24bc42c
Update test/fixtures/es-modules/tla/unresolved-with-worker-process-ex…
MoonBall Jan 3, 2022
adcf374
Update lib/internal/modules/esm/handle_process_exit.js
MoonBall Jan 3, 2022
73e0b71
use isMainThread
MoonBall Jan 4, 2022
d58b5b9
add `handle_process_exit` to bootstrap modules
MoonBall Jan 4, 2022
d7bb21f
move comment to handle_process_exit file
MoonBall Jan 4, 2022
0951516
Update lib/internal/modules/esm/handle_process_exit.js
MoonBall Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move comment to handle_process_exit file
  • Loading branch information
@MoonBall
MoonBall committed Jan 4, 2022
commit d7bb21fcacf9915c36eff5de283688123a4b5a84
4 changes: 4 additions & 0 deletions lib/internal/modules/esm/handle_process_exit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
'use strict';

// Handle a Promise from running code that potentially does Top-Level Await.
// In that case, it makes sense to set the exit code to a specific non-zero
// value if the main code never finishes running.
// The original purpose was https://github.com/nodejs/node/pull/34640
Comment thread
MoonBall marked this conversation as resolved.
Outdated
function handleProcessExit() {
process.exitCode ??= 13;
Comment thread
MoonBall marked this conversation as resolved.
}
Expand Down
3 changes: 0 additions & 3 deletions lib/internal/modules/run_main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ function runMainESM(mainPath) {
}

async function handleMainPromise(promise) {
// Handle a Promise from running code that potentially does Top-Level Await.
// In that case, it makes sense to set the exit code to a specific non-zero
// value if the main code never finishes running.
process.on('exit', handleProcessExit);
try {
return await promise;
Expand Down