Skip to content

test: eliminate multicast test FreeBSD flakiness #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 12 commits into from
Closed

test: eliminate multicast test FreeBSD flakiness #4042

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c623001
test: eliminate multicast test FreeBSD flakiness
Trott Nov 26, 2015
0f2782b
fixup
Trott Nov 27, 2015
8021d83
fixup: skip if in a FreeBSD jail
Trott Nov 28, 2015
0b5c3cb
fixup: drop Buffer import, it is there by default in current Node
Trott Nov 30, 2015
26b56c0
fixup: fix funky indentation
Trott Nov 30, 2015
9b527da
fixup: process.argv[1] -> filename
Trott Nov 30, 2015
fef9193
fixup: hoist workers
Trott Nov 30, 2015
71470b5
fixup: copyedit comments
Trott Nov 30, 2015
615356a
fixup: remove unnecessary killChildren()
Trott Nov 30, 2015
ccafb10
fixup: rm else
Trott Nov 30, 2015
bd8a3c1
fixup: equal->strictEqual
Trott Nov 30, 2015
ec975e4
fixup: typo fix
Trott Nov 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: hoist workers
  • Loading branch information
@Trott
Trott committed Nov 30, 2015
commit fef9193478d5e5b5e28696f9da9629ea7898ede7
13 changes: 7 additions & 6 deletions test/internet/test-dgram-multicast-multi-process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ const messages = [
new Buffer('Third message to send'),
new Buffer('Fourth message to send')
];
const workers = {};
const listeners = 3;


// skip test in FreeBSD jails
if (common.inFreeBSDJail) {
Expand Down Expand Up @@ -111,12 +114,10 @@ function killChildren(children) {
}

if (process.argv[2] !== 'child') {
var workers = {},
listeners = 3,
listening = 0,
dead = 0,
i = 0,
done = 0;
var listening = 0;
var dead = 0;
var i = 0;
var done = 0;

//exit the test if it doesn't succeed within TIMEOUT
var timer = setTimeout(function() {
Expand Down