Skip to content

test: eliminate multicast test FreeBSD flakiness #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 12 commits into from
+150 −151
Closed

test: eliminate multicast test FreeBSD flakiness #4042

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c623001
test: eliminate multicast test FreeBSD flakiness
Trott Nov 26, 2015
0f2782b
fixup
Trott Nov 27, 2015
8021d83
fixup: skip if in a FreeBSD jail
Trott Nov 28, 2015
0b5c3cb
fixup: drop Buffer import, it is there by default in current Node
Trott Nov 30, 2015
26b56c0
fixup: fix funky indentation
Trott Nov 30, 2015
9b527da
fixup: process.argv[1] -> filename
Trott Nov 30, 2015
fef9193
fixup: hoist workers
Trott Nov 30, 2015
71470b5
fixup: copyedit comments
Trott Nov 30, 2015
615356a
fixup: remove unnecessary killChildren()
Trott Nov 30, 2015
ccafb10
fixup: rm else
Trott Nov 30, 2015
bd8a3c1
fixup: equal->strictEqual
Trott Nov 30, 2015
ec975e4
fixup: typo fix
Trott Nov 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: skip if in a FreeBSD jail
  • Loading branch information
@Trott
Trott committed Nov 28, 2015
commit 8021d83f4f02078b065babe56c303094ad622ef4
6 changes: 6 additions & 0 deletions test/internet/test-dgram-multicast-multi-process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ const messages = [
new Buffer('Fourth message to send')
];
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny indent but if the linter is happy...

Copy link
Copy Markdown
Member Author

@Trott Trott Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm doing a bunch of other cosmetic-ish changes on the pre-existing code, I'll fix the funky indent.


// skip test in FreeBSD jails
if (common.inFreeBSDJail) {
console.log('1..0 # Skipped: In a FreeBSD jail');
return;
}

function launchChildProcess(index) {
const worker = fork(process.argv[1], ['child']);
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__filename?

Copy link
Copy Markdown
Member Author

@Trott Trott Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not. process.argv[1] -> __filename it is.

workers[worker.pid] = worker;
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe hoist workers to the top while you're here, it arguably reads easier that way.

Copy link
Copy Markdown
Member Author

@Trott Trott Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that does make it easier to follow. I'll also fix up the remaining bits of the related var statement to make it consistent with the current unofficial standard (separate statements for each var, const where possible).

Expand Down