Skip to content

stream: support array of streams in promises pipeline #40193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mesteery wants to merge 4 commits into from
Closed

stream: support array of streams in promises pipeline #40193

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9ed79f
stream: support array of streams in promises pipeline
Mesteery Sep 23, 2021
7af0af2
fixup! stream: support array of streams in promises pipeline
Mesteery Sep 23, 2021
a7f4073
fixup! fixup! stream: support array of streams in promises pipeline
Mesteery Sep 23, 2021
dbc3a05
Update promises.js
Mesteery Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
stream: support array of streams in promises pipeline 
Fixes: #40191
  • Loading branch information
@Mesteery
Mesteery authored Sep 23, 2021
commit c9ed79fe1cac4eb4f2f0717bc8e9e8540769e35b
6 changes: 6 additions & 0 deletions lib/stream/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const {
ArrayIsArray,
ArrayPrototypePop,
Promise,
} = primordials;
Expand All @@ -23,6 +24,11 @@ function pipeline(...streams) {
signal = options.signal;
}

// pipeline(streams)
if (streams.length === 1 && ArrayIsArray(streams[0])) {
streams = streams[0];
}

pl(streams, (err, value) => {
if (err) {
reject(err);
Expand Down