Skip to content

stream: support array of streams in promises pipeline #40193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mesteery wants to merge 4 commits into from
Closed

stream: support array of streams in promises pipeline #40193

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9ed79f
stream: support array of streams in promises pipeline
Mesteery Sep 23, 2021
7af0af2
fixup! stream: support array of streams in promises pipeline
Mesteery Sep 23, 2021
a7f4073
fixup! fixup! stream: support array of streams in promises pipeline
Mesteery Sep 23, 2021
dbc3a05
Update promises.js
Mesteery Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! stream: support array of streams in promises pipeline
  • Loading branch information
@Mesteery
Mesteery committed Sep 23, 2021
commit a7f4073f0f7b613be37c6d4325388feec793451e
20 changes: 0 additions & 20 deletions test/parallel/test-stream-pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,26 +1407,6 @@ const tsp = require('timers/promises');
ac.abort();
}

{
async function run() {
let finished = false;
const write = new Writable({
write(data, enc, cb) {
cb();
}
});
write.on('finish', () => {
finished = true;
});

await pipelinep([Readable.from('Hello World!'), write]);

assert(finished);
}

run();
}

{
async function run() {
let finished = false;
Expand Down