Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deps: upgrade npm to 6.14.14 #39552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
deps: upgrade npm to 6.14.14 #39552
Changes from 1 commit
fa0c6880e7238addc60c7b11d3f1593212c88425c77ebf36c9b7eb820969b9f5ba2442cac4f90e817ba7e5f9ef697bd33c32033961544e69954217a8189dccebcef689ad96e29b990375e8aeaca1f07e5975bbbc8f3d0d6e8b0862dcea25192fde1e786806232b6f4b2d542f5c2e682262321268703d2268548fd0738a2b392213a64e4837e9cf1203590b5db2ae12d3cce8f5cf1abe4ef39695c3952cf70cf0dc6dfdb0ab31c6c92fd687ace666d7953860bd45e0eb12622c54de6f209b68d84a8a863892573726a4b4ce672a8a36e1906cf65d748178217021cda8eb2fa795ce00381a5ba28d8e5e8735f3359dbbdc15b2631394c6d9d8a394fdec887999380e7872b713682e4462bdff975fedebdc1d6463adfe2148d73ac223e8970fa9c4096a30b27fd072f198b5e32644b5375f2c476bb860646ca1d63897c4f8363bb275ef5960f167a7ba82f2f687270acf03b60570adbe564f24a566cad53b5812b55ed12aa11c4c06c408bb09f4de85b1ea5dec3a09d8c0ca518e4b3fd04e75cccdcc91ec27ff0838a0223625a528639c3bae79009b57f7a99c2302cc13ad4011355c506660cfb7c4f4a9fcb38306051efd40ea42922641bb660e7de8ec5c6a207725e2f1709ad64dbfc07ef4b0776a82b1b55499f693e2a63996cd12be6ad3872e239f5ec12db600d42470eb33cb4cb3c02f1efa8fe44e3822575266a7dbc0f714b26e0f1e936ffdf625b00cac6507e83f7def3260a28e6bfffa79b3f52da9436bcc29e579acb284dec7c7d66d4ea93efd1405a9e057e31dc154c6c42e85c7d0b440cfcddd678f70a0974e319f7959b6da73fcda3cbaabcc0f10006cdd3109fc4c97d9dad3692c18c9e4a9da9536896d7f51e2c323f2852bb1e6c5190beab41c0c97d4c7506ceefa7db0ca87dbc031211d691e630f96803096f42090932c516f2c0479bcfbc6a101b08ef6373840c040d3e56611ef293b38c865bf29fae83c8aead5dc4c65234bb978343f6c3243428a579b5100c3c48ff0a19bc16e6d58f0e071b2df2f1d35332765f2ab6d4e27f6b289344ee6c284dfa1f37d5739f88da653fb484f834ae63ab73d9556a7e0a7228640381019961b7daf6140b3732723aee68357be4a77b1b6316abee7ee6e5b36b8b5c4e673062f8e379f4d5aab03ab4d872aaf05f21bec07d644c08a93f4d47bbafc6de091229d49257312ada0ede1c1354ff5ad6a99497e5f85dc6ee5File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Original commit message: Reland "[liftoff][arm64] Use 64 bit offset reg in mem op" This is a reland of f645d0b857bc669271adcbe95cf25e1554347dd4 The issue was that converting an i64 to an i32 didn't clear the upper bits on arm64. This was not necessary before because we did the zero extension as part of the load operand, but this is required now that we use the full register. Original change's description: > [liftoff][arm64] Use 64 bit offset reg in mem op > > Accessing the Wasm memory with a 64 bit offset was truncated to 32 bit, > which is fine if we check bounds first, but not if we rely on the > trap handler to catch the OOB. > > R=clemensb@chromium.org > > Bug: v8:11587 > Change-Id: I82a3a2906e55d9d640c30e770a5c93532e3a442c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808942 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73829} Bug: v8:11587 Change-Id: Ibc182475745c6f697a0ba6d75c260b74ddf8fe52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810846 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73853} Refs: v8/v8@cb4faa9 PR-URL: #39337 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing