deps: upgrade npm to 6.14.14 #39552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

npm-robot wants to merge 4,159 commits into nodejs:v14.x-staging from npm:npm-6.14.14

Closed

deps: upgrade npm to 6.14.14 #39552

deps: V8: cherry-pick 3d24b3ab8af0

Original commit message:

    ARM64: VRegister::from_code expected to be constexpr

    GCC build fails trying to use a non constexpr function from a
    constexpr function.

    ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h: In member function 'constexpr v8::internal::DoubleRegister v8::internal::wasm::LiftoffRegister::fp() const':
    ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h:286:71: error: call to non-'constexpr' function 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)'
      286 |     return DoubleRegister::from_code(code_ - kAfterMaxLiftoffGpRegCode);
          |                                                                       ^
    In file included from ../chromium-92.0.4503.0/v8/src/codegen/register-arch.h:16,
                     from ../chromium-92.0.4503.0/v8/src/deoptimizer/translation-array.h:8,
                     from ../chromium-92.0.4503.0/v8/src/objects/code.h:10,
                     from ../chromium-92.0.4503.0/v8/src/codegen/reloc-info.h:10,
                     from ../chromium-92.0.4503.0/v8/src/codegen/assembler.h:47,
                     from ../chromium-92.0.4503.0/v8/src/codegen/assembler-arch.h:8,
                     from ../chromium-92.0.4503.0/v8/src/codegen/turbo-assembler.h:12,
                     from ../chromium-92.0.4503.0/v8/src/codegen/macro-assembler.h:8,
                     from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.h:13,
                     from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.cc:5:
    ../chromium-92.0.4503.0/v8/src/codegen/arm64/register-arm64.h:416:20: note: 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)' declared here
      416 |   static VRegister from_code(int code) {
          |                    ^~~~~~~~~

    Bug: chromium:819294
    Change-Id: Ia19ea90f3f666702d32c90e147af17dcda7e08a6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929805
    Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: José Dapena Paz <jdapena@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#74889}

Refs: v8/v8@3d24b3a

PR-URL: #38990
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Loading branch information

targos committed Jul 20, 2021

commit 03096f418b4dc730a8357c67f7c4edad3ad39ea4

common.gypi

-Original file line number
+Diff line change
@@ Expand Up / @@ -36,7 +36,7 @@ @@
         # Reset this number to 0 on major V8 upgrades.
         # Increment by one for each non-official patch applied to deps/v8.
-        'v8_embedder_string': '-node.7',
+        'v8_embedder_string': '-node.8',
         ##### V8 defaults for Node.js #####
@@ Expand Down @@

deps/v8/src/codegen/arm64/register-arm64.h

-Original file line number
+Diff line change
@@ Expand Up / @@ -413,7 +413,7 @@ class VRegister : public CPURegister { @@
       static constexpr int kMaxNumRegisters = kNumberOfVRegisters;
       STATIC_ASSERT(kMaxNumRegisters == kDoubleAfterLast);
-      static VRegister from_code(int code) {
+      static constexpr VRegister from_code(int code) {
         // Always return a D register.
         return VRegister::Create(code, kDRegSizeInBits);
       }
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: upgrade npm to 6.14.14 #39552

Uh oh!

Diff view

Diff view

Uh oh!

There are no files selected for viewing