Skip to content

fs: use a default callback for fs.close() #37174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

fs: use a default callback for fs.close() #37174

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61c243f
fs: use a default callback for fs.close()
jasnell Feb 1, 2021
602d8ba
[Squash] nits
jasnell Feb 4, 2021
e696b41
[Squash] nit
jasnell Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Squash] nit 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@jasnell @aduh95
jasnell and aduh95 authored Feb 4, 2021
commit e696b4185370de395b0d6913de23f4ea11918471
3 changes: 2 additions & 1 deletion lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,8 @@ function defaultCloseCallback(err) {

function close(fd, callback = defaultCloseCallback) {
validateInt32(fd, 'fd', 0);
callback = makeCallback(callback);
if (callback !== defaultCloseCallback)
callback = makeCallback(callback);

const req = new FSReqCallback();
req.oncomplete = callback;
Expand Down