Skip to content

fs: use a default callback for fs.close() #37174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

fs: use a default callback for fs.close() #37174

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61c243f
fs: use a default callback for fs.close()
jasnell Feb 1, 2021
602d8ba
[Squash] nits
jasnell Feb 4, 2021
e696b41
[Squash] nit
jasnell Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Squash] nits 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@jasnell @lpinca
jasnell and lpinca authored Feb 4, 2021
commit 602d8ba79efc43b051d78e051a37b3dc198db577
4 changes: 2 additions & 2 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1622,8 +1622,8 @@ See also: chown(2).
added: v0.0.2
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/00000
description: A default callback is now use if one is not provided.
pr-url: https://github.com/nodejs/node/pull/37174
description: A default callback is now used if one is not provided.
- version: v10.0.0
pr-url: https://github.com/nodejs/node/pull/12562
description: The `callback` parameter is no longer optional. Not passing
Expand Down