Skip to content

module: custom --conditions flag option #34637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 10 commits into from
Closed

module: custom --conditions flag option #34637

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
11928c7
module: custom --conditions flag option
guybedford Aug 5, 2020
5dc585d
fixup resolution bugs
guybedford Aug 5, 2020
936a213
remove condition alias for now
guybedford Aug 5, 2020
e1a91c8
todo is done
guybedford Aug 5, 2020
ed69235
-m alias, docs
guybedford Aug 5, 2020
0180f86
doc reorder
guybedford Aug 5, 2020
dba70c1
rename heading
guybedford Aug 5, 2020
52f216c
use -u short flag
guybedford Aug 5, 2020
acbe3ee
Apply suggestions from code review
guybedford Aug 5, 2020
1ed44a4
use multiple flags over comma separated
guybedford Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
todo is done
  • Loading branch information
@guybedford
guybedford committed Aug 5, 2020
commit e1a91c85d0f040b49ded26a0b46f5a788eca1e95
1 change: 0 additions & 1 deletion lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,6 @@ Module._load = function(request, parent, isMain) {
return module.exports;
};

// TODO: Use this set when resolving pkg#exports conditions.
const cjsConditions = new SafeSet(['require', 'node', ...userConditions]);
Module._resolveFilename = function(request, parent, isMain, options) {
if (NativeModule.canBeRequiredByUsers(request)) {
Expand Down