Skip to content

module: custom --conditions flag option #34637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 10 commits into from
Closed

module: custom --conditions flag option #34637

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
11928c7
module: custom --conditions flag option
guybedford Aug 5, 2020
5dc585d
fixup resolution bugs
guybedford Aug 5, 2020
936a213
remove condition alias for now
guybedford Aug 5, 2020
e1a91c8
todo is done
guybedford Aug 5, 2020
ed69235
-m alias, docs
guybedford Aug 5, 2020
0180f86
doc reorder
guybedford Aug 5, 2020
dba70c1
rename heading
guybedford Aug 5, 2020
52f216c
use -u short flag
guybedford Aug 5, 2020
acbe3ee
Apply suggestions from code review
guybedford Aug 5, 2020
1ed44a4
use multiple flags over comma separated
guybedford Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use -u short flag
  • Loading branch information
@guybedford
guybedford committed Aug 5, 2020
commit 52f216cd0506de9cfca2b40dfd137a94e3e17c92
4 changes: 2 additions & 2 deletions doc/api/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ $ node --completion-bash > node_bash_completion
$ source node_bash_completion
```

### `-m`, `--conditions=conditionA,conditionB`
### `-u`, `--conditions=conditionA,conditionB`
Comment thread
guybedford marked this conversation as resolved.
Outdated
<!-- YAML
added: REPLACEME
-->
Expand Down Expand Up @@ -1247,7 +1247,7 @@ node --require "./a.js" --require "./b.js"

Node.js options that are allowed are:
<!-- node-options-node start -->
* `--conditions`, `-m`
* `--conditions`, `-u`
* `--diagnostic-dir`
* `--disable-proto`
* `--enable-fips`
Expand Down
2 changes: 1 addition & 1 deletion doc/node.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ Aborting instead of exiting causes a core file to be generated for analysis.
.It Fl -completion-bash
Print source-able bash completion script for Node.js.
.
.It Fl m , Fl -conditions Ar string
.It Fl u , Fl -conditions Ar string
Use custom conditional exports conditions
.Ar string
.
Expand Down
2 changes: 1 addition & 1 deletion src/node_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
"set the conditional exports conditions",
Comment thread
guybedford marked this conversation as resolved.
Outdated
&EnvironmentOptions::conditions,
kAllowedInEnvironment);
AddAlias("-m", "--conditions");
AddAlias("-u", "--conditions");
AddOption("--diagnostic-dir",
"set dir for all output files"
" (default: current working directory)",
Expand Down