dns: Add dns/promises alias

nodejs · shisama · Apr 20, 2020 · Apr 28, 2020 · May 6, 2020 · Apr 20, 2020
commit 69041eba941bfbca2d1136307bc6865fe86fcb5c
diff --git a/doc/api/dns.md b/doc/api/dns.md
@@ -611,7 +611,7 @@ earlier ones time out or result in some other error.
 
 The `dns.promises` API provides an alternative set of asynchronous DNS methods
 that return `Promise` objects rather than using callbacks. The API is accessible
-via `require('dns').promises`.
+via `require('dns').promises` or `require('dns/promises')`.
 
 ### Class: `dnsPromises.Resolver`
 <!-- YAML

diff --git a/lib/dns/promises.js b/lib/dns/promises.js
@@ -0,0 +1,3 @@
+'use strict';
+
+module.exports = require('internal/dns/promises');
diff --git a/node.gyp b/node.gyp
@@ -48,6 +48,7 @@
       'lib/cluster.js',
       'lib/dgram.js',
       'lib/dns.js',
+      'lib/dns/promises.js',
       'lib/domain.js',
       'lib/events.js',
       'lib/fs.js',

diff --git a/test/es-module/test-esm-dns-promises.mjs b/test/es-module/test-esm-dns-promises.mjs
@@ -0,0 +1,14 @@
+// Flags: --expose-internals
+import '../common/index.mjs';
+import assert from 'assert';
+import { lookupService } from 'dns/promises';
+
+const invalidAddress = 'fasdfdsaf';
+
+assert.throws(() => {
+  lookupService(invalidAddress, 0);
+}, {
+  code: 'ERR_INVALID_OPT_VALUE',
+  name: 'TypeError',
+  message: `The value "${invalidAddress}" is invalid for option "address"`
+});
diff --git a/test/parallel/test-dns-promises-exists.js b/test/parallel/test-dns-promises-exists.js
@@ -0,0 +1,6 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+
+assert.strictEqual(require('dns/promises'), require('dns').promises);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		'use strict';

		module.exports = require('internal/dns/promises');