Skip to content

dns: Add dns/promises alias #32953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama wants to merge 3 commits into from
Closed

dns: Add dns/promises alias #32953

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69041eb
dns: Add dns/promises alias
shisama Apr 20, 2020
4bfbeff
dns: Add setServers into 'dns/promises'
shisama Apr 28, 2020
44dea35
test: fix dns/promises test
shisama May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix dns/promises test
  • Loading branch information
@shisama
shisama committed May 6, 2020
commit 44dea356f512f812d68174b4260c29fecde3f799
6 changes: 2 additions & 4 deletions test/parallel/test-dns-setservers-type-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,12 @@ const promiseResolver = new dns.promises.Resolver();
// This test for 'dns/promises'
{
const {
setServers,
resolve
setServers
} = require('dns/promises');

// This should not throw any error.
(async () => {
const localhost = await resolve('localhost');
setServers(localhost);
setServers([ '127.0.0.1' ]);
})();

[
Expand Down