Skip to content

v12.16.1 proposal #31781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 12 commits into from
Closed

v12.16.1 proposal #31781

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7a5954e
src: fix -Winconsistent-missing-override warning
cjihrig Nov 19, 2019
f0b2d87
module: 12.x self resolve flag as experimental modules
guybedford Feb 12, 2020
43d02e2
src: keep main-thread Isolate attached to platform during Dispose
addaleax Feb 14, 2020
6d43299
Revert "build: warn upon --use-largepages config option"
MylesBorins Feb 13, 2020
3d5beeb
Revert "src: make large_pages node.cc include conditional"
MylesBorins Feb 13, 2020
a53eeca
Revert "build: switch realpath to pwd"
MylesBorins Feb 13, 2020
7a1b0ac
Revert "build: re-introduce --use-largepages as no-op"
MylesBorins Feb 13, 2020
065a32f
Revert "src: make --use-largepages a runtime option"
MylesBorins Feb 13, 2020
51fdd75
async_hooks: ensure event after been emitted on runInAsyncScope
legendecas Feb 14, 2020
a5bc00a
Revert "events: allow monitoring error events"
MylesBorins Feb 18, 2020
42b68a4
src: inform callback scopes about exceptions in HTTP parser
addaleax Feb 14, 2020
5263cc4
2020-02-18, Version 12.16.1 'Erbium' (LTS)
MylesBorins Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
module: 12.x self resolve flag as experimental modules 
PR-URL: #31757
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
@guybedford @MylesBorins
guybedford authored and MylesBorins committed Feb 13, 2020
commit f0b2d875d96d942d6d22612986dceb225317fede
1 change: 1 addition & 0 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ function resolveBasePath(basePath, exts, isMain, trailingSlash, request) {
}

function trySelf(parentPath, isMain, request) {
if (!experimentalModules) return false;
const { data: pkg, path: basePath } = readPackageScope(parentPath) || {};
if (!pkg || pkg.exports === undefined) return false;
if (typeof pkg.name !== 'string') return false;
Expand Down
16 changes: 16 additions & 0 deletions test/es-module/test-esm-flagged-self.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';

require('../common');
const assert = require('assert');
const path = require('path');
const { createRequireFromPath } = require('module');

const fixturesRequire =
createRequireFromPath(path.resolve(__dirname, '../fixtures/_'));

try {
fixturesRequire('pkgexports/resolve-self');
assert(false);
} catch (e) {
assert.strictEqual(e.code, 'MODULE_NOT_FOUND');
}