Skip to content

v12.16.1 proposal #31781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 12 commits into from
Closed

v12.16.1 proposal #31781

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7a5954e
src: fix -Winconsistent-missing-override warning
cjihrig Nov 19, 2019
f0b2d87
module: 12.x self resolve flag as experimental modules
guybedford Feb 12, 2020
43d02e2
src: keep main-thread Isolate attached to platform during Dispose
addaleax Feb 14, 2020
6d43299
Revert "build: warn upon --use-largepages config option"
MylesBorins Feb 13, 2020
3d5beeb
Revert "src: make large_pages node.cc include conditional"
MylesBorins Feb 13, 2020
a53eeca
Revert "build: switch realpath to pwd"
MylesBorins Feb 13, 2020
7a1b0ac
Revert "build: re-introduce --use-largepages as no-op"
MylesBorins Feb 13, 2020
065a32f
Revert "src: make --use-largepages a runtime option"
MylesBorins Feb 13, 2020
51fdd75
async_hooks: ensure event after been emitted on runInAsyncScope
legendecas Feb 14, 2020
a5bc00a
Revert "events: allow monitoring error events"
MylesBorins Feb 18, 2020
42b68a4
src: inform callback scopes about exceptions in HTTP parser
addaleax Feb 14, 2020
5263cc4
2020-02-18, Version 12.16.1 'Erbium' (LTS)
MylesBorins Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: fix -Winconsistent-missing-override warning 
This commit addresses the following warning:

../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable'
overrides a member function but is not marked 'override'
      [-Winconsistent-missing-override]
  v8::Maybe<bool> mark_arraybuffer_as_untransferable(
                  ^
../src/js_native_api_v8.h:42:27: note: overridden virtual function is here
  virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(

PR-URL: #30549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
  • Loading branch information
@cjihrig @targos
cjihrig authored and targos committed Feb 13, 2020
commit 7a5954ef26c49f53d40a516df60800a119fb9da7
2 changes: 1 addition & 1 deletion src/node_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ {
}

v8::Maybe<bool> mark_arraybuffer_as_untransferable(
v8::Local<v8::ArrayBuffer> ab) const {
v8::Local<v8::ArrayBuffer> ab) const override {
return ab->SetPrivate(
context(),
node_env()->arraybuffer_untransferable_private_symbol(),
Expand Down