Skip to content

test: add known issues test for #31733 #31734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 3 commits into from
+142 −0
Closed

test: add known issues test for #31733 #31734

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b1dfc
test: add known issues test for #31733
bnoordhuis Feb 18, 2020
5d80d47
fixup! add extra sanity check
bnoordhuis Feb 18, 2020
416e214
fixup! remove hasCrypto check
bnoordhuis Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! add extra sanity check
  • Loading branch information
@bnoordhuis
bnoordhuis committed Feb 18, 2020
commit 5d80d47c1bcef3597a26374e7b8a6b8c36f93d7b
11 changes: 11 additions & 0 deletions test/known_issues/test-crypto-authenticated-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,17 @@ function fstream(config) {
// Observation: 'close' comes before 'end' on |c|, which definitely feels
// wrong. Switching to `c.on('end', ...)` doesn't fix the test though.
crypt.on('close', common.mustCall(() => {
// Just to drive home the point that decryption does actually work:
// reading the file synchronously, then decrypting it, works.
{
const ciphertext = fs.readFileSync(filename('b'));
const d = crypto.createDecipheriv(cipher, key, iv, { authTagLength });
d.setAAD(aad, { plaintextLength });
d.setAuthTag(c.getAuthTag());
const actual = Buffer.concat([d.update(ciphertext), d.final()]);
assert.deepStrictEqual(expected, actual);
}

const d = crypto.createDecipheriv(cipher, key, iv, { authTagLength });
d.setAAD(aad, { plaintextLength });
d.setAuthTag(c.getAuthTag());
Expand Down