Skip to content

test: add known issues test for #31733 #31734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 3 commits into from
Closed

test: add known issues test for #31733 #31734

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b1dfc
test: add known issues test for #31733
bnoordhuis Feb 18, 2020
5d80d47
fixup! add extra sanity check
bnoordhuis Feb 18, 2020
416e214
fixup! remove hasCrypto check
bnoordhuis Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! remove hasCrypto check
  • Loading branch information
@bnoordhuis
bnoordhuis committed Feb 18, 2020
commit 416e2143f76e74df9a758d353b1f29c56a51f834
5 changes: 1 addition & 4 deletions test/known_issues/test-crypto-authenticated-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
/* eslint-disable node-core/crypto-check */
Copy link
Copy Markdown
Member

@Trott Trott Feb 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be a bad idea to create a test/known_issues/.eslintrc.yaml and disable the lint rule there, but also probably outside the scope of this PR.

'use strict';
// Refs: https://github.com/nodejs/node/issues/31733
const common = require('../common');

if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const crypto = require('crypto');
const fs = require('fs');
Expand Down