Skip to content

worker: reset Isolate stack limit after entering Locker #31593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
+46 −0
Closed

worker: reset Isolate stack limit after entering Locker #31593

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1755e3
worker: reset `Isolate` stack limit after entering `Locker`
addaleax Jan 31, 2020
3f8f3d6
fixup! worker: reset `Isolate` stack limit after entering `Locker`
addaleax Feb 1, 2020
cbb2051
fixup! fixup! worker: reset `Isolate` stack limit after entering `Loc…
addaleax Feb 1, 2020
0d30c30
fixup! worker: reset `Isolate` stack limit after entering `Locker`
addaleax Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! worker: reset Isolate stack limit after entering Locker
  • Loading branch information
@addaleax
addaleax committed Feb 1, 2020
commit 3f8f3d65ccd4b47f8ed455fda7a7bc18805bad07
4 changes: 0 additions & 4 deletions src/node_worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,6 @@ void Worker::Run() {
{
Locker locker(isolate_);
Isolate::Scope isolate_scope(isolate_);
// V8 computes its stack limit every time a `Locker` is used based on
// --stack-size. Reset it to the correct value.
isolate_->SetStackLimit(stack_base_);

SealHandleScope outer_seal(isolate_);

DeleteFnPtr<Environment, FreeEnvironment> env_;
Expand Down