Skip to content

worker: reset Isolate stack limit after entering Locker #31593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
+46 −0
Closed

worker: reset Isolate stack limit after entering Locker #31593

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1755e3
worker: reset `Isolate` stack limit after entering `Locker`
addaleax Jan 31, 2020
3f8f3d6
fixup! worker: reset `Isolate` stack limit after entering `Locker`
addaleax Feb 1, 2020
cbb2051
fixup! fixup! worker: reset `Isolate` stack limit after entering `Loc…
addaleax Feb 1, 2020
0d30c30
fixup! worker: reset `Isolate` stack limit after entering `Locker`
addaleax Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! worker: reset Isolate stack limit after entering Locker
  • Loading branch information
@addaleax
addaleax committed Feb 4, 2020
commit 0d30c302b61b7d9ae0ebffdc3799fac59ccf46f8
5 changes: 4 additions & 1 deletion test/parallel/test-worker-stack-overflow-stack-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,8 @@ async function runWorker() {
const w1stack = await runWorker();
v8.setFlagsFromString('--stack-size=1000');
const w2stack = await runWorker();
assert.strictEqual(w1stack, w2stack);
// Make sure the two stack sizes are within 10 % of each other, i.e. not
// affected by the different `--stack-size` settings.
assert(Math.max(w1stack, w2stack) / Math.min(w1stack, w2stack) < 1.1,
`w1stack = ${w1stack}, w2stack ${w2stack} are too far apart`);
})().then(common.mustCall());