Skip to content

fs: recursion should bail on permission error #31505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 7 commits into from
Closed

fs: recursion should bail on permission error #31505

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ca2f90
fs: recursion should bail on permission error
Jan 25, 2020
55cd7f4
chore: address code review
Jan 25, 2020
0e1be3c
chore: debugging Windows issue
Jan 25, 2020
47ba6b4
chore: fix up logic to capture error
Jan 26, 2020
6e4ae17
chore: make test work on Windows
Jan 26, 2020
a103161
chore: refactor windows perms logic
Jan 26, 2020
903be10
chore: fix bug with makeDirectoryWritable
Jan 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: fix bug with makeDirectoryWritable
  • Loading branch information
bcoe committed Jan 26, 2020
commit 903be10434c38378ecc1d2e81634d2c30c4a46a1
2 changes: 1 addition & 1 deletion test/parallel/test-fs-mkdir-recursive-eaccess.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function makeDirectoryReadOnly(dir) {

function makeDirectoryWritable(dir) {
if (common.isWindows) {
execSync(`icacls ${dir} /inheritance:e`);
execSync(`icacls ${dir} /grant "everyone":W`);
}
}

Expand Down