Skip to content

fs: recursion should bail on permission error #31505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 7 commits into from
Closed

fs: recursion should bail on permission error #31505

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ca2f90
fs: recursion should bail on permission error
Jan 25, 2020
55cd7f4
chore: address code review
Jan 25, 2020
0e1be3c
chore: debugging Windows issue
Jan 25, 2020
47ba6b4
chore: fix up logic to capture error
Jan 26, 2020
6e4ae17
chore: make test work on Windows
Jan 26, 2020
a103161
chore: refactor windows perms logic
Jan 26, 2020
903be10
chore: fix bug with makeDirectoryWritable
Jan 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fs: recursion should bail on permission error 
When creating directories recursively, the logic should bail
immediately on UV_EACCES and bubble the error to the user.

Fixes: #31481
  • Loading branch information
bcoe committed Jan 25, 2020
commit 4ca2f901e35c9cf787f7b8b38375251ab71063ca
7 changes: 7 additions & 0 deletions src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,6 +1246,9 @@ int MKDirpSync(uv_loop_t* loop,
case UV_EPERM: {
return err;
}
case UV_EACCES: {
return err;
}
Comment thread
addaleax marked this conversation as resolved.
Outdated
default:
uv_fs_req_cleanup(req);
int orig_err = err;
Expand Down Expand Up @@ -1322,6 +1325,10 @@ int MKDirpAsync(uv_loop_t* loop,
req_wrap->continuation_data()->Done(err);
break;
}
case UV_EACCES: {
req_wrap->continuation_data()->Done(err);
break;
}
default:
uv_fs_req_cleanup(req);
// Stash err for use in the callback.
Expand Down
50 changes: 50 additions & 0 deletions test/parallel/test-fs-mkdir-recursive-eaccess.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
'use strict';

// Test that mkdir with recursive option returns appropriate error
// when executed on folder it does not have permission to access.
// Ref: https://github.com/nodejs/node/issues/31481

const common = require('../common');

if (!common.isWindows && process.getuid() === 0)
common.skip('as this test should not be run as `root`');

if (common.isIBMi)
common.skip('IBMi has a different access permission mechanism');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

const assert = require('assert');
const fs = require('fs');
const path = require('path');

let n = 0;

// Synchronous API should return an EACCESS error with path populated.
{
const dir = path.join(tmpdir.path, `mkdirp_${n++}`);
fs.mkdirSync(dir);
fs.chmodSync(dir, '444');
let err = null;
try {
fs.mkdirSync(path.join(dir, '/foo'), { recursive: true });
} catch (_err) {
err = _err;
}
assert(err);
assert.strictEqual(err.code, 'EACCES');
assert(err.path);
}

// Asynchronous API should return an EACCESS error with path populated.
{
const dir = path.join(tmpdir.path, `mkdirp_${n++}`);
fs.mkdirSync(dir);
fs.chmodSync(dir, '444');
fs.mkdir(path.join(dir, '/bar'), { recursive: true }, (err) => {
assert(err);
assert.strictEqual(err.code, 'EACCES');
assert(err.path);
});
}