Skip to content

lib: remove redundant code from timers.js #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

lib: remove redundant code from timers.js #3143

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58199b1
lib: remove redundant code, add tests in timers.js
Trott Oct 1, 2015
4271293
fixup: improve test
Trott Oct 6, 2015
17e09ec
typo fix
Trott Oct 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: improve test
  • Loading branch information
@Trott
Trott committed Oct 6, 2015
commit 42712930c71a3f70feeb26d28336f6a49e0e8530
9 changes: 7 additions & 2 deletions test/parallel/test-timers-active.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@ var legitTimers = [
];

legitTimers.forEach(function(legit) {
const savedTimeout = legit._idleTimeout;
active(legit);
// active() should mutate these objects
assert.notDeepEqual(Object.keys(legit), ['_idleTimeout']);
assert(legit._idleTimeout === savedTimeout);
assert(Number.isInteger(legit._idleStart));
assert(legit._idleNext);
assert(legit._idlePrev);
});


Expand All @@ -22,7 +26,8 @@ var bogusTimers = [
];

bogusTimers.forEach(function(bogus) {
const savedTimeout = bogus._idleTimeout;
active(bogus);
// active() should not mutate these objects
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Oct 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: these?

assert.deepEqual(Object.keys(bogus), ['_idleTimeout']);
assert.deepStrictEqual(bogus, {_idleTimeout: savedTimeout});
});